GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142927: Add scrollbar support to Tachyon HTML dark mode by Wulian233 · Pull Request #148118 · python/cpython

Conversation

@Wulian233

@Wulian233 Wulian233 commented Apr 5, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@hugovk

For compatibility, both approaches must be retained here.

::-webkit-scrollbar offers the widest compatibility, but requires fully customizing the scrollbar.
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Selectors/::-webkit-scrollbar#browser_compatibility
2026-04-04 174623


scrollbar-color is the newer standard, allowing us to style scrollbars without full customization. However, it is not supported by browsers from several years ago.

https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/scrollbar-color#browser_compatibility
2026-04-04 174610

  • Issue: Improve Tachyon UX #142927

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

edvilme reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Wulian233
pythongh-142927: Add scrollbar support to Tachyon HTML dark mode
c8881b9
@Wulian233
Wulian233 requested a review from pablogsal as a code owner April 5, 2026 02:42
@bedevere-app bedevere-app Bot added the awaiting review label Apr 5, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 5, 2026
Improve Tachyon UX #142927
Open
11 tasks done
@hugovk

hugovk commented Apr 5, 2026

Copy link
Copy Markdown
Member

These also apply to light mode, should they? And also * applies to every element.

But more importantly, this may override the user's OS scrollbar settings, which they may have customised for accessibility. Forcing them smaller and darker might mean it's hard for some to control or see.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Wulian233
update
c6504b2
@Wulian233

Wulian233 commented Apr 5, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I adjusted the scope and now only add it where needed

But more importantly, this may override the user's OS scrollbar settings, which they may have customised for accessibility. Forcing them smaller and darker might mean it's hard for some to control or see.

This has been reused according to the existing heatmap design standards, so they should not have much impact:)

cpython/Lib/profiling/sampling/_heatmap_assets/heatmap.css

Lines 815 to 827 in 1f36a51

/* Scrollbar Styling */
.line-content::-webkit-scrollbar {
height: 6px;
}
.line-content::-webkit-scrollbar-thumb {
background: var(--border);
border-radius: 3px;
}
.line-content::-webkit-scrollbar-thumb:hover {
background: var(--text-muted);
}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Wulian233

Wulian233 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

@hugovk @pablogsal May I ask if there are any further changes I need?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Apr 10, 2026

Copy link
Copy Markdown
Member

@hugovk I am good with this PR but I will give you a couple of days before merging in case you have further comments.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Apr 10, 2026

Copy link
Copy Markdown
Member

I don't think we should change the scrollbars, it makes the colour contrast worse and can be harder to use for those who need it.

I don't think the original grey looks bad either.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Wulian233
update
d6f8b71
@Wulian233

Wulian233 commented Apr 11, 2026

Copy link
Copy Markdown
Contributor Author

Alright, I’ll choose to keep only the scrollbar-color, which avoids fully custom styling

When the browser supports this feature, it actually prefers the least intrusive approach

image

This image shows the case where scrollbar-color is not supported and ::-webkit-scrollbar is removed. I think in this situation, some users might perceive it as a design bug. It’s also inconsistent with the existing .line-content::-webkit-scrollbar. The flamegraph doesn’t support dark mode, but the heatmap does

image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Wulian233
Merge branch 'main' into scrollbar
adba9af
@pablogsal
pablogsal requested a review from hugovk April 25, 2026 21:37
hugovk
hugovk reviewed Apr 29, 2026
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing on macOS, with Chrome 143, there's no difference. The scrollbars are already invisible: black on black with no outline. This PR doesn't change this.

Likewise on Safari 263, the scrollbars are black on black, but at least with a dark grey outline, so they're just about visible. This PR doesn't change this either.

On Firefox 149, this PR changes the scrollbars from light grey on black, to a darker grey on black. Both of these are better than Chrome and Safari, but I think it was better before.

If anything, we should be making the scrollbars [more] visible, not less.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Lib/profiling/sampling/_heatmap_assets/heatmap.css
}

/* Scrollbar Styling */
.line-content {

@hugovk hugovk Apr 29, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we already have a .line-content block just before this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Wulian233 @hugovk @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.