GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-142927: Add scrollbar support to Tachyon HTML dark mode by Wulian233 · Pull Request #148118 · python/cpython Conversation
|
|
These also apply to light mode, should they? And also But more importantly, this may override the user's OS scrollbar settings, which they may have customised for accessibility. Forcing them smaller and darker might mean it's hard for some to control or see. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I adjusted the scope and now only add it where needed
This has been reused according to the existing heatmap design standards, so they should not have much impact:) cpython/Lib/profiling/sampling/_heatmap_assets/heatmap.css Lines 815 to 827 in 1f36a51
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@hugovk @pablogsal May I ask if there are any further changes I need? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@hugovk I am good with this PR but I will give you a couple of days before merging in case you have further comments. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I don't think we should change the scrollbars, it makes the colour contrast worse and can be harder to use for those who need it. I don't think the original grey looks bad either. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Testing on macOS, with Chrome 143, there's no difference. The scrollbars are already invisible: black on black with no outline. This PR doesn't change this.
Likewise on Safari 263, the scrollbars are black on black, but at least with a dark grey outline, so they're just about visible. This PR doesn't change this either.
On Firefox 149, this PR changes the scrollbars from light grey on black, to a darker grey on black. Both of these are better than Chrome and Safari, but I think it was better before.
If anything, we should be making the scrollbars [more] visible, not less.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| } | ||
|
|
||
| /* Scrollbar Styling */ | ||
| .line-content { |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Nit: we already have a .line-content block just before this.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 90 days with no activity. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.