GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] bpo-34155: Dont parse domains containing @ (GH-13079) by miss-islington · Pull Request #14825 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 17, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Before:

    >>> email.message_from_string('From: [email protected]@important.com', policy=email.policy.default)['from'].addresses
    (Address(display_name='', username='a', domain='malicious.org'),)

    >>> parseaddr('[email protected]@important.com')
    ('', '[email protected]')

After:

    >>> email.message_from_string('From: [email protected]@important.com', policy=email.policy.default)['from'].addresses
    (Address(display_name='', username='', domain=''),)

    >>> parseaddr('[email protected]@important.com')
    ('', 'a@')

https://bugs.python.org/issue34155
(cherry picked from commit 8cb65d1)

Co-authored-by: jpic [email protected]

https://bugs.python.org/issue34155

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jpic @miss-islington
bpo-34155: Dont parse domains containing @ (pythonGH-13079)
77bb21f 
Before:

        >>> email.message_from_string('From: [email protected]@important.com', policy=email.policy.default)['from'].addresses
        (Address(display_name='', username='a', domain='malicious.org'),)

        >>> parseaddr('[email protected]@important.com')
        ('', '[email protected]')

    After:

        >>> email.message_from_string('From: [email protected]@important.com', policy=email.policy.default)['from'].addresses
        (Address(display_name='', username='', domain=''),)

        >>> parseaddr('[email protected]@important.com')
        ('', 'a@')

https://bugs.python.org/issue34155
(cherry picked from commit 8cb65d1)

Co-authored-by: jpic <[email protected]>
@miss-islington
miss-islington requested a review from a team as a code owner July 17, 2019 21:54
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 17, 2019
@bedevere-bot bedevere-bot mentioned this pull request Jul 17, 2019
bpo-34155: Dont parse domains containing @ #13079
Merged
@bedevere-bot bedevere-bot added type-security A security issue awaiting review labels Jul 17, 2019
@miss-islington

miss-islington commented Jul 17, 2019

Copy link
Copy Markdown
Contributor Author

@jpic: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
maxking
maxking approved these changes Aug 9, 2019
View reviewed changes

@maxking maxking left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport lgtm, merging this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 9, 2019
@miss-islington
miss-islington merged commit c48d606 into python:3.7 Aug 9, 2019
@miss-islington
miss-islington deleted the backport-8cb65d1-3.7 branch August 9, 2019 08:30
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@maxking maxking maxking approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @maxking @the-knights-who-say-ni @bedevere-bot @jpic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.