GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-139423: Fix plistlib to preserve carriage returns in XML plist round-trips by gaweng · Pull Request #148305 · python/cpython

Conversation

@gaweng

@gaweng gaweng commented Apr 9, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

plistlib's _escape() function was normalizing \r\n to \n and \r to \n during XML plist serialization. When the plist was loaded back, the original carriage return characters were lost because expat also normalizes newlines in XML character data.

Fix by encoding \r as the XML character reference instead of converting it to \n. Character references are not subject to XML newline normalization, so expat correctly decodes back to \r, preserving the original data during round-trips.

  • Issue: plistlib inherits expat's newline-normalizing behavior, which can corrupt data in XML plists #139423

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gaweng
pythongh-139423: Fix plistlib to preserve carriage returns in XML pli…
c8f1615
…st round-trips

plistlib's _escape() function was normalizing \r\n to \n and \r to \n
during XML plist serialization. When the plist was loaded back, the
original carriage return characters were lost because expat also
normalizes newlines in XML character data.

Fix by encoding \r as the XML character reference &python#13; instead of
converting it to \n. Character references are not subject to XML
newline normalization, so expat correctly decodes &python#13; back to \r,
preserving the original data during round-trips.
@bedevere-app bedevere-app Bot added the awaiting review label Apr 9, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 9, 2026
plistlib inherits expat's newline-normalizing behavior, which can corrupt data in XML plists #139423
Open
@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@gaweng
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.