GeezerVison is showing github.com — gh-139423: Fix plistlib to preserve carriage returns in XML plist round-trips by gaweng · Pull Request #148305 · python/cpython
Conversation
gaweng
commented
Apr 9, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
plistlib's _escape() function was normalizing \r\n to \n and \r to \n during XML plist serialization. When the plist was loaded back, the original carriage return characters were lost because expat also normalizes newlines in XML character data.
Fix by encoding \r as the XML character reference
instead of converting it to \n. Character references are not subject to XML newline normalization, so expat correctly decodes
back to \r, preserving the original data during round-trips.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…st round-trips
plistlib's _escape() function was normalizing \r\n to \n and \r to \n
during XML plist serialization. When the plist was loaded back, the
original carriage return characters were lost because expat also
normalizes newlines in XML character data.
Fix by encoding \r as the XML character reference &python#13; instead of
converting it to \n. Character references are not subject to XML
newline normalization, so expat correctly decodes &python#13; back to \r,
preserving the original data during round-trips.
|
This PR is stale because it has been open for 30 days with no activity.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.