GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — gh-148285: Allow recording uops after specializing uops by adityakrmishra · Pull Request #148367 · python/cpython Conversation
|
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hmm, while this does allow
Example that violates both: macro(LOAD_SUPER_ATTR) = _LOAD_SUPER_ATTR + // tier1 uop _RECORD_TOS_TYPE + _SPECIALIZE_LOAD_SUPER_ATTR + _PUSH_NULL_CONDITIONAL; BUT, you should wait for a core dev to review this as I may have misunderstood something. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
e35d157 to
639f218
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Sacul0457 Good catch! You are entirely correct—my previous logic conflated all tier1 uops with specializing uops, which was too permissive. I also tangled up the Git history on this branch, so I have closed this PR and opened a clean one with a much stricter positional index check that specifically guards for SPECIALIZE prefixes. The new PR is here: #148373 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Allow recording uops after specializing uops
There was an error while loading. Please reload this page.