GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-37612: always call linkat() from os.link(), if available by jo-he · Pull Request #14843 · python/cpython

Conversation

@jo-he

@jo-he jo-he commented Jul 18, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The issue with link() is, that POSIX does not define its behavior regarding symbolic links:

"If path1 names a symbolic link, it is implementation-defined whether link() follows the symbolic link, or creates a new link to the symbolic link itself."

And it is indeed implemented differently on e.g. Linux and NetBSD. So, it makes no sense to call link(), where linkat() is available.

https://bugs.python.org/issue37612

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jo-he
bpo-37612: always call linkat() from os.link(), if available
ae2e6e8 
The issue with link() is that POSIX does not define its behavior
regarding symbolic links:

"If path1 names a symbolic link, it is implementation-defined whether
link() follows the symbolic link, or creates a new link to the symbolic
link itself."

And it is indeed implemented differently on Linux and NetBSD.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 18, 2019
@bedevere-bot bedevere-bot added the awaiting review label Jul 18, 2019
@blurb-it
📜🤖 Added by blurb_it.
264bdad
@gnprice

gnprice commented Aug 1, 2019

Copy link
Copy Markdown
Contributor

As I understand it from your bpo report, the issue is that the behavior of os.link doesn't match its documentation on some platforms (in particular Linux), and this fixes things so that it does.

In particular the actual behavior on such platforms makes follow_symlinks=True useless, even when explicitly specified, so that's definitely a bug. (Also you located the relevant provision in POSIX and found that Linux's behavior here is perfectly compliant.)

That sounds like a good fix to me!

Would you add a test for it? See test_os.py, or perhaps test_posix.py if the test doesn't make sense to run on Windows.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@takluyver takluyver mentioned this pull request Mar 23, 2021
gh-81793: always call linkat() from os.link(), if available #24997
Closed
@takluyver

takluyver commented Mar 23, 2021

Copy link
Copy Markdown
Contributor

I've had a go at adding the test in #24997.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@bedevere-app bedevere-app Bot mentioned this pull request Apr 14, 2025
os.link(..., follow_symlinks=True) broken on Linux #81793
Closed
@python-cla-bot

python-cla-bot Bot commented Apr 18, 2025

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented May 4, 2025

Copy link
Copy Markdown
Member

Fixed by #132517.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@jo-he @gnprice @takluyver @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.