GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131798: Add `_GET_ITER_TRAD` to JIT optimizer by Wulian233 · Pull Request #148724 · python/cpython

Conversation

@Wulian233

@Wulian233 Wulian233 commented Apr 18, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Wulian233
pythongh-131798: Add _GET_ITER_TRAD to JIT optimizer
1a868d1
@Wulian233
Wulian233 requested review from Fidget-Spinner, markshannon, savannahostrowski and tomasr8 as code owners April 18, 2026 11:43
@bedevere-app bedevere-app Bot added the awaiting review label Apr 18, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 18, 2026
Better uop coverage in the JIT optimizer #131798
Open
@cocolato cocolato added the skip news label Apr 18, 2026
@cocolato

cocolato commented Apr 18, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thankls for doing this.

cpython/Python/optimizer_bytecodes.c

Line 1429 in 7ce737e

ADD_OP(_GET_ITER_TRAD, 0, 0);

But _GET_ITER_TRAD only be added in the output buffer, so this optimization will never be applied now.
Wulian233 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233

Wulian233 commented Apr 18, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for your explanation. It was my oversight that I didn't notice it. So I turned it close first❤️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233 Wulian233 closed this Apr 18, 2026
@Wulian233
Wulian233 deleted the _GET_ITER_TRAD branch April 18, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Wulian233 @cocolato
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.