GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-148211: decompose `_SHUFFLE_3_LOAD_CONST_INLINE_BORROW` in JIT by NekoAsakura · Pull Request #148816 · python/cpython

Conversation

@NekoAsakura

@NekoAsakura NekoAsakura commented Apr 20, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Missed one.

  • Issue: Refactor the JIT uops #148211

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@NekoAsakura
pythongh-148211: decompose _SHUFFLE_2_LOAD_CONST_INLINE_BORROW in JIT
214b506
@NekoAsakura
NekoAsakura requested review from Fidget-Spinner, markshannon, savannahostrowski and tomasr8 as code owners April 20, 2026 23:54
@bedevere-app bedevere-app Bot added the awaiting review label Apr 20, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 20, 2026
Refactor the JIT uops #148211
Closed
@NekoAsakura NekoAsakura changed the title gh-148211: decompose _SHUFFLE_2_LOAD_CONST_INLINE_BORROW in JIT gh-148211: decompose _SHUFFLE_3_LOAD_CONST_INLINE_BORROW in JIT Apr 20, 2026
NekoAsakura added 2 commits April 20, 2026 19:57
@NekoAsakura
pythongh-148211: decompose _SHUFFLE_3_LOAD_CONST_INLINE_BORROW in JIT
5fa6b83
@NekoAsakura
Merge branch 'main' into pythongh-148211/decompose-shuffle-3
b319e64
@cocolato cocolato added the skip news label Apr 21, 2026
cocolato
cocolato approved these changes Apr 21, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Apr 21, 2026
@cocolato

cocolato commented Apr 21, 2026

Copy link
Copy Markdown
Member

LGTM, Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon reviewed Apr 28, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
markshannon merged commit 2b6a137 into python:main Apr 28, 2026
80 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented Apr 28, 2026

Copy link
Copy Markdown
Member

Note:

It might be worth adding ROT_3 and a RROT_3 uops to use in the optimizer and the peepholer.
A SWAP_2; SWAP_3 takes 6 moves, but ROT_3 only takes 4.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 28, 2026
@NekoAsakura
NekoAsakura deleted the gh-148211/decompose-shuffle-3 branch April 28, 2026 16:21
@NekoAsakura NekoAsakura mentioned this pull request Apr 30, 2026
JIT: add _RROT_3 uop to reduce stack moves #149204
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon left review comments
@cocolato cocolato cocolato approved these changes
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@NekoAsakura @cocolato @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.