GeezerVison

Ah this pinged more people than I had anticipated.

This appears to be due to the modification to import_helper.py to allow for testing lazy imports with additional logic.

Documentation build overview

📚 cpython-previews | 🛠️ Build #32570087 | 📁 Comparing c803a10 against main (d206d42)

  🔍 Preview build  

Yes, locally on this branch I'm not though which is a little confusing... All of the lazy import tests are now failing. I assume I'll have to handle the merge conflicts to figure out what's going on?

Inline comments seem to disappear, but wanted to add that it would be nice to make it so parsing args doesn't trigger the lazy import of shutil. It's apparently only used in the HelpFormatter, which intuitively we shouldn't need if we're not showing help. However, that may be a more involved change than we can get in for 3.15.

The shutil usage can probably be replaced - it's an environment variable check and then a call to os.get_terminal_size

I feel ideally we should avoid instantiating the HelpFormatter at all but haven't looked into how hard that is. Having to inline get_terminal_size() would be a bit unfortunate.

Ah, it's #149375

I generally agree on avoiding the HelpFormatter, there seems to be a lot of logic that gets formatted fairly early though.

Overall, this looks great!

The only thing that we may want to consider is that since _colorize is private and _ColorlessTheme exists as an unenforced parallel implementation of ThemeSection.no_colors(), it may be worth adding a small test that imports _colorize, grabs get_theme(force_no_color=True).argparse, iterates its fields, and asserts each is ""?

That's fine, I can do that.

I'm just trying to work out how to stop the import from being triggered due to the changes from #149375

Right now when any argument is added the help check now calls _apply_text_markup on the help string, importing _colorize due to this change https://github.com/DavidCEllis/cpython/blame/43b1c51105944aea17623e47f45294ba6b571c0c/Lib/argparse.py#L714

I cannot believe I have to comment via screenshot but inline comments don't work so...

I think this should be safe to do since it's read only anyway?

Yes! That's what I was looking for. I had got around to turning it off just for _check_help but this is better.

Edit: Now how do I accept a change from a screenshot 😆

Edit: Now how do I accept a change from a screenshot 😆

GitHub employees, if you're listening, I have a Copilot feature request.