GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146609: Use argparse for colour help timeit CLI by hugovk · Pull Request #149334 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented May 3, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Followup to #146610.

Before After
image image

This not only gives us colour help, which is more readable, it improves validation.

We also don't need to show the class info in CLI help.

  • Issue: Add colour to timeit CLI output #146609

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Use argparse for colour help timeit CLI
99835c7
@hugovk hugovk added the stdlib Standard Library Python modules in the Lib/ directory label May 3, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label May 3, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 3, 2026
Add colour to timeit CLI output #146609
Closed
StanFromIreland
StanFromIreland approved these changes May 4, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A few little suggestions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/timeit.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2026-05-03-23-47-59.gh-issue-146609.V9jqYf.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/timeit.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/timeit.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 4, 2026
hugovk
hugovk commented May 4, 2026
View reviewed changes
Comment thread Lib/timeit.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/timeit.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk @StanFromIreland
Apply suggestions from code review
e943110 
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk
hugovk enabled auto-merge (squash) May 4, 2026 08:17
@hugovk

hugovk commented May 4, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit 3506125 into python:main May 4, 2026
50 of 51 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk deleted the 3.15-timeit-argparse branch May 4, 2026 08:44
@bedevere-app bedevere-app Bot removed the awaiting merge label May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.