GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-149358: Generating JIT recorder transformers and stabilizing family layouts by cocolato · Pull Request #149359 · python/cpython

Conversation

@cocolato

@cocolato cocolato commented May 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refer #148730 (comment) and can also help we fix the issue in: #148745

  • Issue: JIT: make recorder layouts stable across opcode families #149358

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cocolato
fix recorder
5617cec
@cocolato
cocolato requested review from Fidget-Spinner and markshannon as code owners May 4, 2026 12:23
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2026
JIT: make recorder layouts stable across opcode families #149358
Closed
@bedevere-app bedevere-app Bot added the awaiting review label May 4, 2026
@cocolato cocolato added the skip news label May 4, 2026
@read-the-docs-community

read-the-docs-community Bot commented May 4, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32525708 | 📁 Comparing 5617cec against main (2ba0a81)

  🔍 Preview build  

3 files changed
± library/calendar.html
± whatsnew/3.15.html
± whatsnew/changelog.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cocolato cocolato mentioned this pull request May 4, 2026
gh-143732: add specialization for FOR_ITER #148745
Merged
cocolato added 5 commits May 5, 2026 11:54
@cocolato
Merge branch 'main' into jit_record_family
ee8f452
@cocolato
regen record functions
1ab2f02
@cocolato
fix merge
beeff33
@cocolato
minimize diff
e801489
@cocolato
minimize diff
6061301
markshannon
markshannon requested changes May 19, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with a couple more tests, but looks good otherwise

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cocolato reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Lib/test/test_generated_cases.py
op(_DO_STUFF, (tos -- res)) {
res = tos;
}
macro(OP) = _RECORD_TOS + _DO_STUFF;

@markshannon markshannon May 19, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for:

  • Base op does not record, but specialization does
  • Base op does record, but specialization does not

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/cases_generator/analyzer.py Outdated
size: str
members: list[Instruction]

@property

@markshannon markshannon May 19, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a normal function? It is quite heavyweight for a property

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels May 19, 2026
@bedevere-app

bedevere-app Bot commented May 19, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cocolato added 2 commits May 20, 2026 17:24
@cocolato
Merge branch 'main' into jit_record_family
677220b
@cocolato
address review
cc1c6b6
@cocolato

cocolato commented May 20, 2026

Copy link
Copy Markdown
Member Author

Thanks for review ! I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels May 20, 2026
@bedevere-app

bedevere-app Bot commented May 20, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from markshannon May 20, 2026 10:09
markshannon
markshannon approved these changes May 21, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting change review labels May 21, 2026
@markshannon
markshannon merged commit 0828782 into python:main May 21, 2026
84 of 87 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 21, 2026
@cocolato
cocolato deleted the jit_record_family branch May 23, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cocolato @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.