GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-139489: Add xml.is_valid_text() by serhiy-storchaka · Pull Request #149412 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 5, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add utility functions to test for legal XML characters and names #139489

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka
pythongh-139489: Add xml.is_valid_text()
89700b6
@serhiy-storchaka
serhiy-storchaka requested a review from AA-Turner as a code owner May 5, 2026 12:13
@bedevere-app bedevere-app Bot mentioned this pull request May 5, 2026
Add utility functions to test for legal XML characters and names #139489
Open
@bedevere-app bedevere-app Bot added the awaiting core review label May 5, 2026
@read-the-docs-community

read-the-docs-community Bot commented May 5, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32563801 | 📁 Comparing 0ab7f48 against main (426f99c)

  🔍 Preview build  

10 files changed · ± 10 modified

± Modified

  • c-api/type.html
  • library/datatypes.html
  • library/difflib.html
  • library/pprint.html
  • library/ssl.html
  • library/unittest.mock.html
  • library/xml.html
  • tutorial/stdlib2.html
  • whatsnew/3.15.html
  • whatsnew/changelog.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented May 5, 2026

Copy link
Copy Markdown
Member

What do you think of adding also a sanitize function which takes a callback? Example:

import re

ILLEGAL_XML_CHARS_RE = re.compile(
    '['
    # Control characters; newline (\x0A and \x0D) and TAB (\x09) are legal
    '\x00-\x08\x0B\x0C\x0E-\x1F'
    # Surrogate characters
    '\uD800-\uDFFF'
    # Special Unicode characters
    '\uFFFE'
    '\uFFFF'
    # Match multiple sequential invalid characters for better efficiency
    ']+')

def sanitize(text, replace_func):
    def callback(regs):
        return replace_func(regs[0])

    return ILLEGAL_XML_CHARS_RE.sub(callback, text)

def escape(text):
    return ''.join(f'\\x{ord(char):02x}' for char in text)

invalid = '\x00'
test = f'a{invalid}b'
print(sanitize(test, lambda text: '#' * len(text)))
print(sanitize(test, escape))

It would be useful for sanitize_xml() of Lib/test/libregrtest/utils.py.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland
StanFromIreland reviewed May 5, 2026
View reviewed changes
Comment thread Doc/library/xml.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/xml.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka
serhiy-storchaka commented May 5, 2026
View reviewed changes
Comment thread Doc/library/xml.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka @StanFromIreland
Apply suggestions from code review
2523e52
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka

serhiy-storchaka commented May 5, 2026

Copy link
Copy Markdown
Member Author

What do you think of adding also a sanitize function which takes a callback?

I left it for a separate PR. I have similar function in a different branch. But it accepts also the name of the registered error handler ('strict', 'ignore', 'replace, 'backslashreplace', etc) and the callback has different interface. It needs a separate discussion.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner
vstinner approved these changes May 6, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Misc/NEWS.d/next/Library/2026-05-05-13-12-58.gh-issue-139489.a8qqIM.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 6, 2026
@vstinner

vstinner commented May 6, 2026

Copy link
Copy Markdown
Member

I left it for a separate PR. (...). It needs a separate discussion.

Ok, that makes sense.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka @vstinner
Update Misc/NEWS.d/next/Library/2026-05-05-13-12-58.gh-issue-139489.a…
0ab7f48
…8qqIM.rst

Co-authored-by: Victor Stinner <[email protected]>
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) May 6, 2026 14:11
@serhiy-storchaka
serhiy-storchaka merged commit a5c7a74 into python:main May 6, 2026
55 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label May 6, 2026
@serhiy-storchaka
serhiy-storchaka deleted the xml-is_valid_text-1.0 branch July 1, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@vstinner vstinner vstinner approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @vstinner @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.