GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-149486: tarfile.data_filter: validate written link target (GH-149487) by miss-islington · Pull Request #149556 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 8, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The data filter rewrote linknames with normpath() but ran the
containment check against the un-normalised value, and computed a
symlink's directory before stripping trailing slashes. Both let a
crafted archive create links pointing outside the destination. Also
reject link members that resolve to the destination directory itself,
which could otherwise replace it with a symlink and redirect all
subsequent members.

(Patch by Greg; Petr's just reviewing & merging.)
(cherry picked from commit 5784119)

Co-authored-by: Petr Viktorin [email protected]
Co-authored-by: Gregory P. Smith [email protected]

  • Issue: tarfile.data_filter doesn't handle symlinks with empty names #149486

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou @gpshead @miss-islington
pythongh-149486: tarfile.data_filter: validate written link target (p…
6df9892
…ythonGH-149487)

The data filter rewrote linknames with normpath() but ran the
containment check against the un-normalised value, and computed a
symlink's directory before stripping trailing slashes.  Both let a
crafted archive create links pointing outside the destination.  Also
reject link members that resolve to the destination directory itself,
which could otherwise replace it with a symlink and redirect all
subsequent members.

(Patch by Greg; Petr's just reviewing & merging.)
(cherry picked from commit 5784119)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington
miss-islington requested a review from ethanfurman as a code owner May 8, 2026 12:16
This was referenced May 8, 2026
tarfile.data_filter doesn't handle symlinks with empty names #149486
Closed
gh-149486: tarfile.data_filter: validate written link target #149487
Merged
@bedevere-app bedevere-app Bot added the awaiting review label May 8, 2026
@read-the-docs-community

read-the-docs-community Bot commented May 8, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32606778 | 📁 Comparing af3856f against main (2f6b380)

  🔍 Preview build  

533 files changed · + 3 added · ± 477 modified · - 53 deleted

+ Added

  • c-api/objbuffer.html
  • library/2to3.html
  • library/tkinter.tix.html

± Modified

  • about.html
  • bugs.html
  • copyright.html
  • glossary.html
  • index.html
  • license.html
  • py-modindex.html
  • c-api/abstract.html
  • c-api/allocation.html
  • c-api/apiabiversion.html
  • and 467 more...

- Deleted

  • 404.html
  • improve-page-nojs.html
  • improve-page.html
  • _static/tachyon-example-flamegraph.html
  • _static/tachyon-example-heatmap.html
  • c-api/curses.html
  • c-api/extension-modules.html
  • c-api/interp-lifecycle.html
  • c-api/lifecycle.html
  • c-api/monitoring.html
  • and 43 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou
Move dotdot_resolves_early setting to setUpClass
af3856f
encukou
encukou approved these changes May 11, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 11, 2026
@gpshead gpshead added type-security A security issue release-blocker labels May 13, 2026
@github-project-automation github-project-automation Bot added this to Release and Deferred blockers 🚫 May 13, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Release and Deferred blockers 🚫 May 13, 2026
@Yhg1s
Yhg1s merged commit 0d28f5e into python:3.12 May 18, 2026
31 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@github-project-automation github-project-automation Bot moved this from Todo to Done in Release and Deferred blockers 🚫 May 18, 2026
@bedevere-app bedevere-app Bot removed the awaiting merge label May 18, 2026
@miss-islington
miss-islington deleted the backport-5784119-3.12 branch May 18, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release-blocker type-security A security issue

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @encukou @gpshead @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.