GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-148675: Reuse typecodes for array.array() error message by vstinner · Pull Request #149779 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 13, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

array.array() error message now reuses array.typecodes, instead of maintaining an hardcoded list of valid type codes.

  • Issue: Add support for numpy buffer format Zf and Zd #148675

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-148675: Reuse typecodes for array.array() error message
5c4379c
array.array() error message now reuses array.typecodes, instead of
maintaining an hardcoded list of valid type codes.
@vstinner vstinner added the skip news label May 13, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 13, 2026
Add support for numpy buffer format Zf and Zd #148675
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 13, 2026
@vstinner

vstinner commented May 13, 2026

Copy link
Copy Markdown
Member Author

Example:

import array
array.array('v')

Output:

Traceback (most recent call last):
  File "/home/vstinner/python/main/x.py", line 2, in <module>
    array.array('v')
    ~~~~~~~~~~~^^^^^
ValueError: bad typecode (must be: b, B, u, w, h, H, i, I, l, L, q, Q, e, f, d, Zf, Zd)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev
skirpichev approved these changes May 14, 2026
View reviewed changes
@vstinner
vstinner merged commit a8ef467 into python:main May 15, 2026
56 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner deleted the array_errmsg branch May 15, 2026 11:22
@bedevere-app bedevere-app Bot removed the awaiting core review label May 15, 2026
@vstinner

vstinner commented May 15, 2026

Copy link
Copy Markdown
Member Author

Merged, thanks for the review.

I wrote this change since recently, I noticed that 3 type codes were missing from this error message. I fixed the error message, but with this change it's no longer neeeded (it's always up to date).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @skirpichev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.