GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-148200: Update Modules/_hacl/ for Cygwin by vstinner · Pull Request #149802 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 13, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This pulls an updated version of HACL* that fixes Lib_Memzero0.c on Cygwin, via an upstream fix.

  • Issue: CYGWIN: warning on missing safe memzero() is printed #148200

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested review from gpshead, picnixz and sethmlarson as code owners May 13, 2026 20:15
@vstinner vstinner added the skip news label May 13, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 13, 2026
CYGWIN: warning on missing safe memzero() is printed #148200
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 13, 2026
@vstinner

vstinner commented May 13, 2026

Copy link
Copy Markdown
Member Author

I regenerated the SBOM with:

sed -i -e s/8ba599b2f6c9701b3dc961db895b0856a2210f76/504c2987452f87fe44bce9b9f12e19d6e051761f/g Misc/sbom.spdx.json 
make regen-sbom
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request May 13, 2026
gh-148200: fix warning on missing safe memzero() on CYGWIN #148202
Closed
@vstinner

vstinner commented May 13, 2026

Copy link
Copy Markdown
Member Author

cc @protz @picnixz
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
pythongh-148200: Update Modules/_hacl/ for Cygwin
ef34850 
This pulls an updated version of HACL* that fixes Lib_Memzero0.c on
Cygwin, via an upstream fix.
@vstinner
vstinner force-pushed the update_hacl branch from 1235667 to ef34850 Compare May 13, 2026 20:22
@vstinner

vstinner commented May 13, 2026

Copy link
Copy Markdown
Member Author

Hum. It seems like the checksums of the hacl-star package is outdated in Misc/sbom.spdx.json, but I don't know how to regenerate it. I expected python3.14 ./Tools/build/generate_sbom.py to update it, but I already ran this command.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented May 13, 2026

Copy link
Copy Markdown
Member

Running with the CI envvar generates the correct checksum:

stan@stanlaptop:~/dev/cpython{update_hacl}$ CI=1 make regen-sbom
python3.15 ./Tools/build/generate_sbom.py
stan@stanlaptop:~/dev/cpython{update_hacl}$ git diff
diff --git a/Misc/sbom.spdx.json b/Misc/sbom.spdx.json
index f42487bebee..cea3abebd17 100644
--- a/Misc/sbom.spdx.json
+++ b/Misc/sbom.spdx.json
@@ -1024,7 +1024,7 @@
       "checksums": [
         {
           "algorithm": "SHA256",
-          "checksumValue": "61e48893f37cb2280d106cefacf6fb5afe84edf625fec39572d0ee94e1018f26"
+          "checksumValue": "d6db56a5d061dcc0890eabdbb5f58a9fa6c606d9f2fbbe9d626925b870ffadfb"
         }
       ],
       "downloadLocation": "https://github.com/hacl-star/hacl-star/archive/504c2987452f87fe44bce9b9f12e19d6e051761f.zip",
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented May 13, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Yeah it's intentional:

cpython/Tools/build/generate_sbom.py

Line 193 in ef34850

if "checksums" not in package or "CI" in os.environ:

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Run CI=1 make regen-sbom
48fc299
@vstinner

vstinner commented May 13, 2026

Copy link
Copy Markdown
Member Author

Ah yes, CI=1 make regen-sbom regenerates properly the checksums. https://devguide.python.org/developer-workflow/sbom/#updating-a-dependency documentation should maybe document CI=1.

cc @sethmlarson
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit a0551b1 into python:main May 15, 2026
55 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the update_hacl branch May 15, 2026 12:42
@bedevere-app bedevere-app Bot removed the awaiting core review label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner
@sethmlarson sethmlarson Awaiting requested review from sethmlarson sethmlarson is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.