GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-149879: Don't import msvcrt in _pyio on Cygwin by vstinner · Pull Request #149899 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 15, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The msvcrt extension module cannot be built on Cygwin.

  • Issue: Enhance Cygwin support #149879

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

embray reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vstinner
pythongh-149879: Don't import msvcrt in _pyio on Cygwin
7addb4f
The msvcrt extension module cannot be built on Cygwin.
@vstinner vstinner added the skip news label May 15, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 15, 2026
Enhance Cygwin support #149879
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 15, 2026
@vstinner

vstinner commented May 15, 2026

Copy link
Copy Markdown
Member Author

This change fix a regression introduced by commit f0f55a0 in 2015. It does fix the issue reported in 2016: #69069 (comment).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner mentioned this pull request May 15, 2026
_pyio checks that os.name == 'win32' instead of 'nt' #69069
Closed
@vstinner
vstinner enabled auto-merge (squash) May 15, 2026 20:20
@vstinner

vstinner commented May 15, 2026

Copy link
Copy Markdown
Member Author

The macos-26 job failed with:

FAIL: test_trampoline_works_with_forks (test.test_perf_profiler.TestPerfTrampoline.test_trampoline_works_with_forks)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/cpython/cpython/Lib/test/test_perf_profiler.py", line 145, in test_trampoline_works_with_forks
    self.assertEqual(process.returncode, 0)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 11 != 0

That's the unrelated issue gh-149156.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit 1441f2f into python:main May 15, 2026
93 of 95 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner deleted the pyio branch May 15, 2026 21:11
@bedevere-app bedevere-app Bot removed the awaiting core review label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.