GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-86533: Restore os.makedirs() ability to apply *mode* recursively (GH-150011) by miss-islington · Pull Request #150036 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 18, 2026 •
edited by gpshead
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

bpo-42367: Restore os.makedirs() and pathlib.mkdir() ability to apply mode recursively via a new parent_mode= keyword argument.
(cherry picked from commit 9770e32)

Co-authored-by: nessita [email protected]
Co-authored-by: Zackery Spytz [email protected]
Co-authored-by: Erlend E. Aasland [email protected]
Co-authored-by: Natalia [email protected]
Co-authored-by: Gregory P. Smith [email protected]

  • Issue: Restore os.makedirs ability to apply mode to all directories created #86533

Fixes #86533

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nessita @ZackerySpytz
@erlend-aasland @gpshead @miss-islington
pythongh-86533: Restore os.makedirs() ability to apply *mode* recursi…
08dca1e 
…vely (pythonGH-150011)

bpo-42367: Restore os.makedirs() and pathlib.mkdir() ability to apply *mode* recursively via a new parent_mode= keyword argument.
(cherry picked from commit 9770e32)

Co-authored-by: nessita <[email protected]>
Co-authored-by: Zackery Spytz <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Natalia <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington
miss-islington requested review from AA-Turner and barneygale as code owners May 18, 2026 23:00
@bedevere-app bedevere-app Bot mentioned this pull request May 18, 2026
Restore os.makedirs ability to apply mode to all directories created #86533
Closed
@bedevere-app bedevere-app Bot added sprint type-bug An unexpected behavior, bug, or error type-feature A feature request or enhancement type-security A security issue labels May 18, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 18, 2026
gh-86533: Restore os.makedirs() ability to apply *mode* recursively #150011
Merged
@bedevere-app bedevere-app Bot added the awaiting review label May 18, 2026
@github-project-automation github-project-automation Bot added this to Sprint May 18, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Sprint May 18, 2026
@gpshead
gpshead enabled auto-merge (squash) May 18, 2026 23:03
gpshead
gpshead approved these changes May 18, 2026
View reviewed changes
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint May 18, 2026
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 18, 2026
@gpshead
gpshead disabled auto-merge May 18, 2026 23:19
@gpshead

gpshead commented May 18, 2026

Copy link
Copy Markdown
Member

there's some buildbot failures (the joy of tests relying on filesystem modes in various environments) on the first PR. I'll deal with those and incorporate fixes here before merging this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead
pythongh-86533: Make Path.mkdir parent_mode tests umask-independent
036510e 
test_mkdir_with_parent_mode, test_mkdir_parent_mode_deep_hierarchy and
test_mkdir_parent_mode_same_as_mode assert exact directory mode bits but
did not pin the process umask.  On buildbots running with a restrictive
umask (e.g. 0o077) the 0o755 leaf was masked down to 0o700, failing the
assertions.  Wrap them in os_helper.temp_umask(0o022), matching the
other umask-aware mkdir tests in this file.
@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 18, 2026
@bedevere-bot

bedevere-bot commented May 18, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 036510e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F150036%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 18, 2026
@gpshead
gpshead merged commit 28f275f into python:3.15 May 19, 2026
117 of 121 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 19, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Sprint May 19, 2026
@miss-islington
miss-islington deleted the backport-9770e32-3.15 branch May 19, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

sprint type-bug An unexpected behavior, bug, or error type-feature A feature request or enhancement type-security A security issue

Projects

Sprint
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @gpshead @bedevere-bot @nessita
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.