GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-150045: Add `frozendict` support to the compiler and AST constants by lgeiger · Pull Request #150050 · python/cpython

Conversation

@lgeiger

@lgeiger lgeiger commented May 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This adapts the compiler to treat frozendict as a valid constant similar to frozenset:

  • 37d8189 adds frozendict to ast constants
  • b027839 adds support for deduplication via _PyCode_ConstantKey
  • 992b4b6 adds recursive constant merging which make
  • aeed04a fixes the freethreading case

Let me know if you'd like me to split this up into separate PRs, this has become a much larger than I had originally intended.

  • Issue: Add support for frozendict as AST Constant #150045

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lgeiger added 3 commits May 19, 2026 02:09
@lgeiger
Add frozendict to ast constants
37d8189
@lgeiger
Add frozendict support to _PyCode_ConstantKey
b027839
@lgeiger
Add frozendict support for recursive constant merging
992b4b6
@lgeiger
lgeiger requested review from Eclips4, JelleZijlstra, iritkatriel, isidentical, markshannon and tomasr8 as code owners May 19, 2026 01:24
@bedevere-app bedevere-app Bot added the awaiting review label May 19, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2026
Add support for frozendict as AST Constant #150045
Closed
@lgeiger
Fix free-threading
aeed04a
@lgeiger
lgeiger requested a review from methane as a code owner May 19, 2026 02:38
@lgeiger
Merge branch 'main' into ast-frozendict
0650ab2
@picnixz

picnixz commented May 19, 2026

Copy link
Copy Markdown
Member

The consensus on the issue is not reached and there is still opposition, hence marking as pending.
lgeiger and Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz added the DO-NOT-MERGE label May 19, 2026
@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 19, 2026
@lgeiger lgeiger closed this Aug 19, 2026
@lgeiger
lgeiger deleted the ast-frozendict branch August 19, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
@Eclips4 Eclips4 Awaiting requested review from Eclips4 Eclips4 is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@methane methane Awaiting requested review from methane methane is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lgeiger @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.