GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "gh-146452: Improve locking granularity in pickle's batch_dict_exact and fix race condition (#150025)" by vstinner · Pull Request #150261 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 22, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 57a0e57.

  • Issue: Segfault in _pickle.c:batch_dict_exact when pickling dict with concurrent mutation (free-threading) #146452

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
Revert "pythongh-146452: Improve locking granularity in pickle's batc…
19211e5 
…h_dict_exact and fix race condition (python#150025)"

This reverts commit 57a0e57.
@bedevere-app bedevere-app Bot mentioned this pull request May 22, 2026
Segfault in _pickle.c:batch_dict_exact when pickling dict with concurrent mutation (free-threading) #146452
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 22, 2026
@vstinner vstinner mentioned this pull request May 22, 2026
gh-146452: Improve locking granularity in pickle's batch_dict_exact #150025
Merged
@vstinner

vstinner commented May 22, 2026

Copy link
Copy Markdown
Member Author

cc @JelleZijlstra @colesbury @kumaraditya303
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit b770b23 into python:main May 22, 2026
57 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the revert_pickle_dict branch May 22, 2026 20:22
@bedevere-app bedevere-app Bot removed the awaiting core review label May 22, 2026
@vstinner

vstinner commented May 22, 2026

Copy link
Copy Markdown
Member Author

I merged the PR. There was an increasing number of "exit code 143" failures. CI job failed again when re-run, it was more and more annoying.
colesbury and scopreon reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request May 22, 2026
gh-150257: Skip test_free_threading.test_pickle #150260
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.