GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132578: Add regression test ensuring Thread subclasses can safely define _handle by Vaibhav-S-Gowda · Pull Request #150322 · python/cpython

Conversation

@Vaibhav-S-Gowda

@Vaibhav-S-Gowda Vaibhav-S-Gowda commented May 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

This PR introduces a dedicated regression test to Lib/test/test_threading.py to prevent future namespace collisions on the _handle attribute within the threading.Thread class lifecycle.

Rationale

In Python 3.13, the introduction of an internal _handle tracking parameter inadvertently shadowed custom _handle methods or attributes defined by third-party frameworks (such as gevent) which subclass threading.Thread. While the core engine has since migrated its internal variable to _os_thread_handle to resolve the conflict, an explicit test suite assertion was missing. This regression test ensures that user-defined subclasses can natively implement a custom self._handle attribute without interfering with standard library operations or causing unexpected runtime behavior.

Verification

  • Ran the local test suite on the modified source tree: ./python -m test test_threading -v
  • Verified that all 246 tests completed successfully with zero regressions or errors.
  • Issue: Introduction of Thread._handle: _thread._ThreadHandle in Python3.13 has broken an unknown number of packages #132578

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Vaibhav-S-Gowda
gh-132578: Add regression test ensuring Thread subclasses can safely …
dd0c198
…define _handle
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label May 23, 2026
@bedevere-app

bedevere-app Bot commented May 23, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot mentioned this pull request May 23, 2026
Introduction of Thread._handle: _thread._ThreadHandle in Python3.13 has broken an unknown number of packages #132578
Open
@bedevere-app bedevere-app Bot added the awaiting review label May 23, 2026
@Vaibhav-S-Gowda
gh-132578: Add news blurb to Library and fix test layout spacing
81e7a6c
@picnixz

picnixz commented May 23, 2026

Copy link
Copy Markdown
Member

This is an unnecessary test.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@picnixz picnixz closed this May 23, 2026
@picnixz

picnixz commented May 23, 2026

Copy link
Copy Markdown
Member

And please read https://devguide.python.org/getting-started/generative-ai to understand our stand about AI. PRs that are just generated by AI for contribution points will be rejected and users banned from interacting with the repository should they abuse this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Vaibhav-S-Gowda @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.