GeezerVison is showing github.com — gh-132578: Add regression test ensuring Thread subclasses can safely define _handle by Vaibhav-S-Gowda · Pull Request #150322 · python/cpython
Conversation
Vaibhav-S-Gowda
commented
May 23, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
This PR introduces a dedicated regression test to Lib/test/test_threading.py to prevent future namespace collisions on the _handle attribute within the threading.Thread class lifecycle.
Rationale
In Python 3.13, the introduction of an internal _handle tracking parameter inadvertently shadowed custom _handle methods or attributes defined by third-party frameworks (such as gevent) which subclass threading.Thread. While the core engine has since migrated its internal variable to _os_thread_handle to resolve the conflict, an explicit test suite assertion was missing. This regression test ensures that user-defined subclasses can natively implement a custom self._handle attribute without interfering with standard library operations or causing unexpected runtime behavior.
Verification
- Ran the local test suite on the modified source tree:
./python -m test test_threading -v
- Verified that all 246 tests completed successfully with zero regressions or errors.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.
If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
This is an unnecessary test.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.