GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-150114: Log the memory usage in regrtest on macOS by corona10 · Pull Request #150396 · python/cpython

Conversation

@corona10

@corona10 corona10 commented May 25, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: GitHub free threading CI failing with SIGTERM #150114

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-150114: Log the memory usage in regrtest on macOS
7327561
@corona10
corona10 requested a review from vstinner May 25, 2026 13:04
@corona10 corona10 added the skip news label May 25, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 25, 2026
GitHub free threading CI failing with SIGTERM #150114
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 25, 2026
@corona10

corona10 commented May 25, 2026

Copy link
Copy Markdown
Member Author

cc @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented May 25, 2026

Copy link
Copy Markdown
Member Author

!buildbot macOS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 25, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 7327561 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F150396%2Fmerge

The command will test the builders whose names match following regular expression: macOS

The builders matched are:

  • x86-64 MacOS Intel NoGIL PR
  • x86-64 MacOS Intel ASAN NoGIL PR
  • x86-64 macOS PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 MacOS M1 NoGIL PR
  • ARM64 macOS PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 mentioned this pull request May 25, 2026
gh-150114: Log the memory usage in regrtest on FreeBSD #150280
Merged
@corona10
fix for iOS
03abe46
@corona10

corona10 commented May 25, 2026

Copy link
Copy Markdown
Member Author

!buildbot macOS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 25, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 03abe46 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F150396%2Fmerge

The command will test the builders whose names match following regular expression: macOS

The builders matched are:

  • x86-64 MacOS Intel NoGIL PR
  • x86-64 MacOS Intel ASAN NoGIL PR
  • x86-64 macOS PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 MacOS M1 NoGIL PR
  • ARM64 macOS PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed May 25, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently, code to get the memory usage of the current process was removed from the GC: https://github.com/python/cpython/pull/149475/changes#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204dL2022. I used task_info(mach_task_self(), TASK_VM_INFO, ...) and gets vm_info.phys_footprint. In private, @corona10 told me that task_info() cannot be used to get the memory usage of other processes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vstinner

vstinner commented May 25, 2026

Copy link
Copy Markdown
Member

psutil also uses proc_pidinfo(PROC_PIDTASKINFO) API to get the RSS memory of a process: https://github.com/giampaolo/psutil/blob/1a2569db0b2ad7489539ad6b6b6b85cb13b755f7/psutil/arch/osx/proc.c#L136-L154.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Merge remote-tracking branch 'upstream/main' into pythongh-150114-macos
e3870ab
@corona10

corona10 commented May 25, 2026

Copy link
Copy Markdown
Member Author

!buildbot macOS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 25, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit e3870ab 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F150396%2Fmerge

The command will test the builders whose names match following regular expression: macOS

The builders matched are:

  • x86-64 MacOS Intel NoGIL PR
  • x86-64 MacOS Intel ASAN NoGIL PR
  • x86-64 macOS PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 MacOS M1 NoGIL PR
  • ARM64 macOS PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed May 25, 2026
View reviewed changes
Comment thread Modules/_testcapi/mem.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Address code review
f31e283
@corona10
corona10 requested a review from vstinner May 25, 2026 14:13
@vstinner vstinner mentioned this pull request May 25, 2026
gh-150114: Use get_process_memory_usage() in memory watchdog #150402
Merged
vstinner
vstinner reviewed May 25, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should run make clinic, no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_testcapi/mem.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented May 25, 2026

Copy link
Copy Markdown
Member Author

You should run make clinic, no?

Why? I didnt use AC at here
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Address code review
526034a
vstinner
vstinner approved these changes May 25, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the macOS jobs in GitHub Action and macOS jobs on buildbots are happy with this change.

I don't have access to macOS to test the PR.

Why? I didnt use AC at here

Oops, you're right. I was confused by other C functions using AC.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 25, 2026
@corona10
corona10 merged commit c714b56 into python:main May 25, 2026
56 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 25, 2026
@corona10
corona10 deleted the gh-150114-macos branch May 25, 2026 15:03
@vstinner

vstinner commented May 25, 2026

Copy link
Copy Markdown
Member

Thanks for adding macOS support!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@corona10 @bedevere-bot @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.