GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-149879: Fix test_asyncio on Cygwin by vstinner · Pull Request #150416 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 25, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Skip tests on UNIX sockets since they hang on Cygwin.

  • Issue: Enhance Cygwin support #149879

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-149879: Fix test_asyncio on Cygwin
02f8375 
Skip tests on UNIX sockets since they hang on Cygwin.
@vstinner vstinner added the skip news label May 25, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 25, 2026
Enhance Cygwin support #149879
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 25, 2026
@vstinner

vstinner commented May 25, 2026

Copy link
Copy Markdown
Member Author

The fix is incomplete, the following tests still fail:

test_asyncio.test_events
    test_ssl_connect_accepted_socket()
    test_subprocess_kill()
    test_subprocess_terminate()
    test_subprocess_send_signal()
    test_subprocess_stderr()
    test_subprocess_stderr_redirect_to_stdout()

test_asyncio.test_ssl
    test_remote_shutdown_receives_trailing_data_on_slow_socket()

test_asyncio.test_subprocess
    test_cancel_post_init()
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Use a socketpair for stdin
c6bf314
@vstinner
vstinner requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners May 25, 2026 20:08
@vstinner

vstinner commented May 25, 2026

Copy link
Copy Markdown
Member Author

I found a fix for subprocess tests (use a socketpair for stdin).

test_remote_shutdown_receives_trailing_data_on_slow_socket() stil hangs. It can be fixed later.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit be715d7 into python:main May 25, 2026
49 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the test_asyncio branch May 25, 2026 20:54
@bedevere-app bedevere-app Bot removed the awaiting core review label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.