GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-149879: Fix test_httpservers on Cygwin by vstinner · Pull Request #150417 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 25, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Enhance Cygwin support #149879

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-149879: Fix test_httpservers on Cygwin
3faf644
@vstinner vstinner added the skip news label May 25, 2026
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels May 25, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 25, 2026
Enhance Cygwin support #149879
Closed
@vstinner

vstinner commented May 25, 2026

Copy link
Copy Markdown
Member Author

BaseHTTPSServerTestCase and test_https_client() still fail with this PR. But I propose disabling the ssl module on Cygwin for now, since many tests are failing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 25, 2026

Copy link
Copy Markdown
Member Author

BaseHTTPSServerTestCase and test_https_client() still fail with this PR. But I propose disabling the ssl module on Cygwin for now, since many tests are failing.

These tests pass with the ssl PR gh-150419.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented May 25, 2026

Copy link
Copy Markdown
Member

But I propose disabling the ssl module on Cygwin for now, since many tests are failing.

Disabling it seems a good way to fix the problems indeed. We need to investigate more the reason why SSL on cygwin is struggling before fixing each test one by one (I prefer having the big picture first because we may introduce subtle issues if we do a case-by-case)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 25, 2026

Copy link
Copy Markdown
Member Author

Disabling it seems a good way to fix the problems indeed. We need to investigate more the reason why SSL on cygwin is struggling before fixing each test one by one (I prefer having the big picture first because we may introduce subtle issues if we do a case-by-case)

I changed my mind. It's no longer needed to disable the ssl module, since I have a working fix for ssl on Cygwin: PR gh-150419.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) May 25, 2026 19:41
@vstinner
vstinner merged commit 71fa314 into python:main May 25, 2026
95 of 97 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the test_httpservers branch May 25, 2026 19:50
@bedevere-app bedevere-app Bot removed the awaiting core review label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.