GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-149879: Fix test_ftplib on Cygwin by vstinner · Pull Request #150431 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 25, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Skip test_abort() since MSG_OOB doesn't work properly on Cygwin. The server gets b'\n' and then b'ABOR\r', instead of getting b'ABOR\r\n'.

  • Issue: Enhance Cygwin support #149879

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-149879: Fix test_ftplib on Cygwin
e88a8fb 
Skip test_abort() since MSG_OOB doesn't work properly on Cygwin. The
server gets b'\n' and then b'ABOR\r', instead of getting b'ABOR\r\n'.
@vstinner
vstinner requested a review from giampaolo as a code owner May 25, 2026 21:34
@vstinner vstinner added the skip news label May 25, 2026
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels May 25, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 25, 2026
Enhance Cygwin support #149879
Closed
@vstinner

vstinner commented May 25, 2026

Copy link
Copy Markdown
Member Author

I found a reference to MSG_OOB in Cygwin in 2018 with this fix: https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=9c84bfd47922aad4881f80243320422b621c95dc. Well, it's supposed to be fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
giampaolo
giampaolo approved these changes May 25, 2026
View reviewed changes

@giampaolo giampaolo left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 25, 2026
@vstinner
vstinner merged commit 5ab1e86 into python:main May 25, 2026
59 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the test_ftplib branch May 25, 2026 22:09
@bedevere-app bedevere-app Bot removed the awaiting merge label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giampaolo giampaolo giampaolo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @giampaolo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.