GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-150582: Use _winapi for _pyrepl console handles and waits by aisk · Pull Request #150584 · python/cpython

Conversation

@aisk

@aisk aisk commented May 29, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Replace ctypes based Windows console calls in _pyrepl #150582

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aisk
Use _winapi for _pyrepl console handles and waits
d77c46e
@aisk
aisk requested review from ambv, lysnikolaou and pablogsal as code owners May 29, 2026 17:41
@bedevere-app bedevere-app Bot mentioned this pull request May 29, 2026
Replace ctypes based Windows console calls in _pyrepl #150582
Open
2 of 8 tasks
@bedevere-app bedevere-app Bot added the awaiting review label May 29, 2026
aisk added 2 commits May 30, 2026 02:45
@aisk
Use _winapi calls directly in _pyrepl
8d3ef98
@aisk
Move _winapi import with other imports
4dfefb8
@aisk aisk added the skip news label May 29, 2026
aisk added 5 commits May 30, 2026 03:00
@aisk
Fix mypy for _winapi usage in _pyrepl
3ff96ae
@aisk
Remove redundant type: ignore for _winapi.WaitForSingleObject
24331a9
@aisk
Fix mypy
f55b7a5
@aisk
Reduce codes
cf13fbd
@aisk
Use STD handle consts from _winapi
3c8917f
@zooba

zooba commented Jun 1, 2026

Copy link
Copy Markdown
Member

LGTM! Will let the pyrepl maintainers do the merge (looks like the CI failures are unrelated, and pretty sure they have fixes in progress).
chris-eibl reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 30, 2026
@aisk
Merge branch 'main' into pyrepl-native-call
9e67216
@aisk aisk removed the stale Stale PR or inactive for long period of time. label Aug 31, 2026
chris-eibl
chris-eibl approved these changes Sep 11, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 11, 2026
@chris-eibl

chris-eibl commented Sep 11, 2026

Copy link
Copy Markdown
Member

LGTM, too.

Will let the pyrepl maintainers do the merge

cc @ambv / @pablogsal
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aisk
Merge branch 'main' into pyrepl-native-call
9a8ed02
@aisk

aisk commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

Hi @zooba @chris-eibl, I think this PR is small and only affects Windows. Could we go ahead and merge it if @ambv and @pablogsal don't have time to review it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chris-eibl

chris-eibl commented Oct 25, 2026

Copy link
Copy Markdown
Member

Yupp, let's go. At Europython, I spoke with @ambv, and he's okay with me merging PRs like this one.
aisk reacted with thumbs up emoji aisk reacted with laugh emoji
All reactions
  • 👍 1 reaction
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chris-eibl
Merge branch 'main' into pyrepl-native-call
f39777d
@chris-eibl
chris-eibl enabled auto-merge (squash) October 25, 2026 09:45
@chris-eibl
chris-eibl merged commit 2468c35 into python:main Oct 25, 2026
59 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 25, 2026
@chris-eibl

chris-eibl commented Oct 25, 2026

Copy link
Copy Markdown
Member

Merged, @aisk thanks for your contribution.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aisk
aisk deleted the pyrepl-native-call branch October 25, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-eibl chris-eibl chris-eibl approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@aisk @zooba @chris-eibl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.