GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145177: Bump emscripten version to 5.0.7 by hoodmane · Pull Request #150896 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Jun 4, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Update the Emscripten compiler toolchain.

  • Issue: Emscripten buildbot: Support multiple Emscripten versions #145177

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-145177: Bump emscripten version to 5.0.7
4699148
@hoodmane
hoodmane requested review from emmatyping and freakboy3742 as code owners June 4, 2026 00:11
@bedevere-app bedevere-app Bot mentioned this pull request Jun 4, 2026
Emscripten buildbot: Support multiple Emscripten versions #145177
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jun 4, 2026
@hoodmane hoodmane added skip news OS-emscripten needs backport to 3.15 bugs and security fixes and removed awaiting review labels Jun 4, 2026
freakboy3742
freakboy3742 requested changes Jun 4, 2026
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the "new emscripten version" tooling worked as advertised... but exposed some fun runtime issues in the test suite.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting changes label Jun 4, 2026
@bedevere-app

bedevere-app Bot commented Jun 4, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane

hoodmane commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Yeah I guess I'll have to debug what went wrong with ctypes. Maybe I can bisect the last good version...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742

freakboy3742 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Closing this now that we've bumped to 4.0.19
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742 freakboy3742 closed this Jun 5, 2026
@hoodmane

hoodmane commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Well that is less of course.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742

freakboy3742 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Well that is less of course.

Oh sure; I closed this PR down because I assumed 4.0.19 was where we were going to leave things for now. Rather than leave an open PR in the queue, I figured we should close this one down.

If you want to re-open it to keep getting to the bottom of the ctypes problem, go right ahead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane

hoodmane commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

I will if I figure it out.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 requested changes
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes needs backport to 3.15 bugs and security fixes OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hoodmane @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.