GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-150887: Fix Traversable abstractmethod docs by iamrajhans · Pull Request #150918 · python/cpython

Conversation

@iamrajhans

@iamrajhans iamrajhans commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Remove stale abstractmethod markers from importlib.resources.abc.Traversable.joinpath and truediv docs. These methods have concrete implementations.\n\nFixes gh-150887.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@iamrajhans
pythongh-150887: Fix Traversable abstractmethod docs
bfab48c
@iamrajhans
iamrajhans requested review from FFY00, jaraco and warsaw as code owners June 4, 2026 13:03
@bedevere-app bedevere-app Bot added the awaiting review label Jun 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 4, 2026
importlib.resources.abc.Traversable.joinpath is still marked as abstract after implementation #150887
Open
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jun 4, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Jun 4, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jun 4, 2026
@read-the-docs-community

read-the-docs-community Bot commented Jun 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33718882 | 📁 Comparing 4def1ea against main (a96cba5)

  🔍 Preview build  

193 files changed · + 4 added · ± 188 modified · - 1 deleted

+ Added

  • library/asyncio-threading.html
  • library/asyncio-tools.html
  • library/tkinter.fontchooser.html
  • library/tkinter.systray.html

± Modified

  • glossary.html
  • py-modindex.html
  • c-api/bytes.html
  • c-api/coro.html
  • c-api/dict.html
  • c-api/exceptions.html
  • c-api/extension-modules.html
  • c-api/float.html
  • c-api/frame.html
  • c-api/gen.html
  • and 178 more...

- Deleted

  • library/asyncio-policy.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iamrajhans
Merge branch 'main' into issue-150887-importlib-docs
b4f1c2c
@Andrew5057

Andrew5057 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

From a comment on the issue:

The implications of this in the context of a protocol are too subtle for me to feel up to proposing actual documentation text.

One option is just to not provide any doc text; the protocol inheritance semantics have more to do with protocols in general than this particular one. Alternatively, a prefix along the lines of "For classes that explicitly subclass Traversable, the default implementation..." might be sufficient?

The relevant spec is in the typing docs, though linking that might be overkill.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iamrajhans added 4 commits June 16, 2026 12:39
@iamrajhans
Merge branch 'main' into issue-150887-importlib-docs
5276caa
@iamrajhans
Merge branch 'main' into issue-150887-importlib-docs
447e494
@iamrajhans
Merge branch 'main' into issue-150887-importlib-docs
01f6890
@iamrajhans
Merge branch 'main' into issue-150887-importlib-docs
4def1ea
@github-actions

github-actions Bot commented Oct 28, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iamrajhans @Andrew5057
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.