GeezerVison

Thanks for the early review @StanFromIreland !

I'm not seeing my new test in checks, but it does show up as a failure in "All required checks pass". Not sure how to dig in from here.

Edit: Fixed!

@hugovk I added the check to make sure the excluded list of tests still fail.

Oddly, a lot of the ones that were failing locally for me & failing in the original issue stopped failing on CI? This was a bit surprising/confusing? cc: @JelleZijlstra

Edit: It was a bug, addressing in commit.

A few thoughts:

• Is this important enough to warrant adding a new GH Action? Should it be a buildbot instead?
• It's possible some of the failing modules in my issue were due to unrelated problems in my environment; I don't often run the full test suite locally.

Also we need to add some mechanism (decorator?) to mark tests as expected to fail under lazy imports = all. My issue mentioned a few scenarios, like a test relying on the import side effect of creating a pyc file.

Also we need to add some mechanism (decorator?) to mark tests as expected to fail under lazy imports = all. My issue mentioned a few scenarios, like a test relying on the import side effect of creating a pyc file.

We could use unittest.skipIf to check if lazy imports all is set.

Addressed comments! Thanks for the review @StanFromIreland

Thanks again @StanFromIreland. Let me know if there's anything else that needs updating.

Alright, I think we're good! @StanFromIreland