GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146102: Catch PyErr_NewException() failure in zlib by vstinner · Pull Request #151342 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 11, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Umbrella issue: bugs found using cpython-review-toolkit #146102

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-146102: Catch PyErr_NewException() failure in zlib
015f253
@vstinner vstinner added the skip news label Jun 11, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 11, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 11, 2026
Umbrella issue: bugs found using cpython-review-toolkit #146102
Open
@vstinner

vstinner commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

See the report: https://gist.github.com/devdanzin/ada54523342276bbdb66228de2ec863e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland reviewed Jun 11, 2026
View reviewed changes
Comment thread Modules/zlibmodule.c
if (state->ZlibError == NULL) {
return -1;
}
if (PyModule_AddObjectRef(mod, "error", state->ZlibError) < 0) {

@StanFromIreland StanFromIreland Jun 11, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't strictly necessary, PyModule_AddObjectRef will return -1 if it's NULL. Looking at other modules, they also follow this pattern.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Jun 11, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you're right! I checked PyModule_AddObjectRef() documentation and it's well documented:

To be convenient, the function accepts NULL value with an exception
set. In this case, return -1 and just leave the raised exception
unchanged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vstinner

vstinner commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

This change is not needed. I close the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Jun 11, 2026
@vstinner
vstinner deleted the zlib branch June 11, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.