GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-37763: Teach setup.py to pick up "-isystem <dir>" from $CPPFLAGS by jherland · Pull Request #15136 · python/cpython

Conversation

@jherland

@jherland jherland commented Aug 5, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

When (cross-)compiling, setup.py will pick up header search dirs from
$CPPFLAGS and lib search dirs from $LDFLAGS. However, the code only
looks at the -I options in $CPPFLAGS to find header search dirs.

Using the -isystem option (instead of -I) to pass header search dirs is
also a valid option, but this is currently unsupported by setup.py.

This patch adds handling of -isystem options, so that these are picked
up the same way that -I options currently are.

https://bugs.python.org/issue37763

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jherland
bpo-37763: Teach setup.py to pick up "-isystem <dir>" from $CPPFLAGS
08d5948 
When (cross-)compiling, setup.py will pick up header search dirs from
$CPPFLAGS and lib search dirs from $LDFLAGS. However, the code only
looks at the -I options in $CPPFLAGS to find header search dirs.

Using the -isystem option (instead of -I) to pass header search dirs is
also a valid option, but this is currently unsupported by setup.py.

This patch adds handling of -isystem options, so that these are picked
up the same way that -I options currently are.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 5, 2019
@bedevere-bot bedevere-bot added the awaiting review label Aug 5, 2019
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@jherland jherland mannequin mentioned this pull request Apr 10, 2022
Need setup.py to pick up -isystem flags from CPPFLAGS #81944
Closed
@erlend-aasland

erlend-aasland commented Dec 27, 2023

Copy link
Copy Markdown
Contributor

Thanks for you PR. setup.py is no longer part of the code base.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jherland @erlend-aasland @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.