GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — gh-132312: Significantly reduce thread state lookups in the interpreter by ZeroIntensity · Pull Request #151453 · python/cpython Conversation
|
|
Do you have some numbers on how much we gain with this dance? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Nothing conclusive yet, no. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm having a lot of trouble getting consistent benchmarks, unfortunately. My system seems to be too jittery to get a reliable result. I also don't know why the JIT CI is failing on Windows. @Fidget-Spinner -- do you have advice for either of these? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@ZeroIntensity JIT on Windows requires whatever is used in bytecodes.c to be an exported symbol. In this case it's complaining memcpy is not available. Are you using that? If so, you need to add the relevant header to template.c |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I didn't add anything that uses |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It could be indirectly used as well through an inlined function. In any case, unless string.h is included by Python.h or the other pycores by default it wont be included https://github.com/python/cpython/blob/main/Tools/jit/template.c |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 90 days with no activity. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.