GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-151422: Don't link libffi into _ctypes_test.so (GH-151423) by miss-islington · Pull Request #151516 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 15, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

_ctypes_test doesn't use libffi directly, and linking it into the module
causes emscripten tests to fail.
(cherry picked from commit 8646385)

Co-authored-by: Hood Chatham [email protected]

  • Issue: libffi is linked into _ctypes_test.so but not actually used there #151422

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane @miss-islington
pythongh-151422: Don't link libffi into _ctypes_test.so (pythonGH-151423
4f487fc 
)

_ctypes_test doesn't use libffi directly, and linking it into the module
causes emscripten tests to fail.
(cherry picked from commit 8646385)

Co-authored-by: Hood Chatham <[email protected]>
@miss-islington
miss-islington requested review from AA-Turner, corona10, emmatyping and erlend-aasland as code owners June 15, 2026 22:16
@bedevere-app bedevere-app Bot added the awaiting review label Jun 15, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 15, 2026
libffi is linked into _ctypes_test.so but not actually used there #151422
Closed
@bedevere-app bedevere-app Bot added the skip news label Jun 15, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 15, 2026
gh-151422: Don't link libffi into _ctypes_test.so #151423
Merged
freakboy3742
freakboy3742 approved these changes Jun 15, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 15, 2026
@freakboy3742
freakboy3742 enabled auto-merge (squash) June 15, 2026 22:17
@freakboy3742
freakboy3742 merged commit e2c7fa7 into python:3.15 Jun 15, 2026
61 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 15, 2026
@miss-islington
miss-islington deleted the backport-8646385-3.15 branch June 15, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @freakboy3742 @hoodmane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.