GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146102: Avoid possibe memory leak in `pylifecycle.c` by IvyXu420 · Pull Request #151534 · python/cpython

Conversation

@IvyXu420

@IvyXu420 IvyXu420 commented Jun 16, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Umbrella issue: bugs found using cpython-review-toolkit #146102

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
IvyXu420 added 2 commits June 16, 2026 16:08
@IvyXu420
Avoid possibe memory leak in pylifecycle.c
725ae61
@IvyXu420
Add news entry
c6037e2
@IvyXu420
IvyXu420 requested review from FFY00, ZeroIntensity and ericsnowcurrently as code owners June 16, 2026 08:22
@bedevere-app bedevere-app Bot added the awaiting review label Jun 16, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 16, 2026
Umbrella issue: bugs found using cpython-review-toolkit #146102
Open
@Wulian233

Wulian233 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

I have already made a similar PR before. However, if yours is better, I will close mine
#149631
IvyXu420 reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 17, 2026
BHUVANSH855
BHUVANSH855 reviewed Oct 22, 2026
View reviewed changes

@BHUVANSH855 BHUVANSH855 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you have a look on these points.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/pylifecycle.c

@BHUVANSH855 BHUVANSH855 Oct 22, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pycore_init_builtins still leaks bimod on the _PyBuiltin_InitPythonFunctions early return (inside config->_install_importlib). Also the two fixed sites should be Py_DECREF not Py_XDECREF, bimod is non-NULL there.

new_interpreter: _PyObject_InitState and _PyStats_InterpInit failure checks still return status instead of goto error, skipping _PyThreadState_Attach.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-06-16-16-19-42.gh-issue-146102.xtcD4F.rst

@BHUVANSH855 BHUVANSH855 Oct 22, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests were added. I think Lib/test/test_interpreters/test_lifecycle.py would be right place.

NEWS entry should reference gh-149630, not gh-146102 (that's the umbrella).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
1 more reviewer
@BHUVANSH855 BHUVANSH855 BHUVANSH855 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@IvyXu420 @Wulian233 @BHUVANSH855
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.