GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-151678: Add tests for tkinter.filedialog (GH-151781) by miss-islington · Pull Request #151796 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 20, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Exercise the native dialogs (Open, SaveAs and Directory) through the
_test_callback seam without opening them, and test the pure-Python
FileDialog selection, filter and ok/cancel logic without entering its
modal loop.
(cherry picked from commit 58fd9ec)

Co-authored-by: Serhiy Storchaka [email protected]
Co-authored-by: Claude Opus 4.8 [email protected]

  • Issue: Improve test coverage of tkinter #151678

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @claude @miss-islington
pythongh-151678: Add tests for tkinter.filedialog (pythonGH-151781)
8a8c466 
Exercise the native dialogs (Open, SaveAs and Directory) through the
_test_callback seam without opening them, and test the pure-Python
FileDialog selection, filter and ok/cancel logic without entering its
modal loop.
(cherry picked from commit 58fd9ec)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Opus 4.8 <[email protected]>
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 20, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 20, 2026
Improve test coverage of tkinter #151678
Closed
@bedevere-app bedevere-app Bot added the skip news label Jun 20, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 20, 2026
gh-151678: Add tests for tkinter.filedialog #151781
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jun 20, 2026
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) June 20, 2026 13:22
@serhiy-storchaka
serhiy-storchaka merged commit 5090fbc into python:3.14 Jun 20, 2026
86 of 88 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Jun 20, 2026
@miss-islington
miss-islington deleted the backport-58fd9ec-3.14 branch June 20, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.