GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-151943: Fix incorrect interface names in xml.sax.rst by manoj-marimuthu · Pull Request #151961 · python/cpython

Conversation

@manoj-marimuthu

@manoj-marimuthu manoj-marimuthu commented Jun 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The following PR addresses aims to remove the warnings from sphinx that are raised for xml.sax.rst. (total 3 warnings)

Warnings removed:

WARNING: py:class reference target not found: xml.sax.xmlreader.Attributes [ref.class]
WARNING: py:class reference target not found: xml.sax.xmlreader.AttributesNS [ref.class]
  • The above warnings were removed by replacing xml.sax.xmlreader.Attributes with xml.sax.xmlreader.AttributesImpl and
    xml.sax.xmlreader.AttributesNS with xml.sax.xmlreader.AttributesNSImpl.

Verification :

  • for xml.sax.xmlreader.AttributesImpl : xml.sax.reader.rst
  • for xml.sax.xmlreader.AttributesNSImpl: xml.sax.reader.rst

Warnings remaining:

WARNING: py:func reference target not found: create_parser [ref.func]
  • The above warning is due to the absence of documentation for create_parser function. We can either add documentation for it or remove the documentation's reference to create_parser. Waiting for suggestions.
  • Issue: Fix all Sphinx reference warnings in Doc/library/{xml*,pyexpat}.rst #151943

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@manoj-marimuthu
Fix incorrect interface names in xml.sax.rst
fb2cf16
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jun 23, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Jun 23, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jun 23, 2026
@bedevere-app bedevere-app Bot added the awaiting review label Jun 23, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 23, 2026
Fix all Sphinx reference warnings in Doc/library/{xml*,pyexpat}.rst #151943
Open
@read-the-docs-community

read-the-docs-community Bot commented Jun 23, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34185026 | 📁 Comparing 9079d6e against main (3f09a17)

  🔍 Preview build  

195 files changed · + 3 added · ± 191 modified · - 1 deleted

+ Added

  • library/asyncio-tools.html
  • library/tkinter.fontchooser.html
  • library/tkinter.systray.html

± Modified

  • glossary.html
  • index.html
  • license.html
  • py-modindex.html
  • c-api/arg.html
  • c-api/bytes.html
  • c-api/capsule.html
  • c-api/dict.html
  • c-api/exceptions.html
  • c-api/extension-modules.html
  • and 181 more...

- Deleted

  • library/asyncio-policy.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@harjothkhara harjothkhara mentioned this pull request Jul 1, 2026
gh-151945: Fix reference warnings in http.cookiejar and http.server docs #152815
Closed
StanFromIreland
StanFromIreland reviewed Jul 2, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for create_parser, please add a reference (.. _sax-parser-modules:) to the note at the top of the xml.sax.reader documentation. We can then expand that note.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/library/xml.sax.rst Outdated
and :class:`~xml.sax.xmlreader.XMLReader` interfaces are defined in the
module :mod:`xml.sax.xmlreader`. The handler interfaces are defined in
:mod:`xml.sax.handler`. For convenience,
:class:`~xml.sax.xmlreader.AttributesImpl`,

@StanFromIreland StanFromIreland Jul 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should instead link to :ref:`Attributes <attributes-objects>` and :ref:`AttributesNS <attributes-ns-objects>`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
manoj-marimuthu added 3 commits July 2, 2026 17:53
@manoj-marimuthu
Fix references to Attribute interfaces and create reference for parse…
456066e
…r modules in xml.sax.rst and xml.sax.reader.rst respectively
@manoj-marimuthu
remove repeatition of attributesNS
19f576e
@manoj-marimuthu
Fix spacings
e64e3f4
@manoj-marimuthu
manoj-marimuthu requested a review from StanFromIreland July 2, 2026 12:39
StanFromIreland
StanFromIreland reviewed Jul 2, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't actually fix the issue with create_parser? Please change it to a reference as I noted before. You should then be able to remove the file from .nitignore.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/library/xml.sax.rst Outdated
:class:`~xml.sax.xmlreader.InputSource` (which is often
instantiated directly) and the handler classes are also available from
:mod:`!xml.sax`. These interfaces are described below.
:ref:`Attributes <attributes-objects>`,:ref:`AttributesNS <attributes-ns-objects>`,

@StanFromIreland StanFromIreland Jul 2, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/library/xml.sax.rst Outdated
:mod:`!xml.sax`. These interfaces are described below.
:ref:`Attributes <attributes-objects>`,:ref:`AttributesNS <attributes-ns-objects>`,
and :class:`~xml.sax.xmlreader.XMLReader` interfaces are defined in the module
:mod:`xml.sax.xmlreader`. The handler interfaces are defined in

@StanFromIreland StanFromIreland Jul 2, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep double spacing for consistency.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@manoj-marimuthu
Add reference to create_parser(), fix spacing in xml.sax.rst
b094606
@manoj-marimuthu
manoj-marimuthu requested review from AA-Turner and hugovk as code owners July 3, 2026 01:00
@manoj-marimuthu

manoj-marimuthu commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@StanFromIreland I believe I have added the reference now, I am new to sphinx.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@manoj-marimuthu
manoj-marimuthu requested a review from StanFromIreland July 5, 2026 10:35
@manoj-marimuthu

manoj-marimuthu commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@StanFromIreland A gentle reminder.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@manoj-marimuthu
Merge branch 'main' into fix-sphinx-warnings-in-doc-lib-xml
9079d6e
@manoj-marimuthu manoj-marimuthu closed this Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@manoj-marimuthu @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.