GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-21109: Add SafeTarFile by epicfaace · Pull Request #15244 · python/cpython

Conversation

@epicfaace

@epicfaace epicfaace commented Aug 13, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Working off of the patch in bpo-21109; adding the tests so that all tests that apply to FileTest also apply to SafeFileTest. It's a bit tricky in this case because of multiple inheritance of the test classes.

https://bugs.python.org/issue21109

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
epicfaace added 9 commits August 13, 2019 00:28
@epicfaace
apply safetarfile-4.diff
7b28c5d
@epicfaace
doc: remove duplicate message
12a5074
@epicfaace
add TarFileTest and SafeTarFileTest
a95ce6a
@epicfaace
test: fix inheritance of tests to make it easier to extend
a3bcc18
@epicfaace
add test inheritance of TarFileTest to all testcases
2f8990d
@epicfaace
test: replace tarfile.open with tarfile_open
769eb32
@epicfaace
test: replace tarfile.TarFile with self.tarfile_module
8e522b4
@epicfaace
test: make taropen generic
8f361c1
@epicfaace
Rename to -base because there's already a class called SafeTarFileTest
b6862c6
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 13, 2019
@bedevere-bot bedevere-bot added the awaiting review label Aug 13, 2019
epicfaace added 6 commits August 13, 2019 04:44
@epicfaace
Add some tests for SafeTarFile
bfe20da
@epicfaace
test: move safetarfile to another test module
6011e26
@epicfaace
keep only working safetarfile tests
18f7b30
@epicfaace
add ustarreadtests
c58262b
@epicfaace
enable one failing safetarfile test
b3fa18a
@epicfaace
Update tarfile.rst
14b88fe
@DanielGarcia DanielGarcia mannequin mentioned this pull request Apr 10, 2022
tarfile: Traversal attack vulnerability #65308
Closed
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@encukou

encukou commented Jun 19, 2025

Copy link
Copy Markdown
Member

Superseded by PEP-706. A safe(r) option is now the default.
Thank you for this attempt!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou closed this Jun 19, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Sep 22, 2026
fix: block unsafe tar extraction paths qdrant/fastembed#647
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman will be requested when the pull request is marked ready for review ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@epicfaace @encukou @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.