GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-152433: Windows: ``_winapi.c`` implement ``GetVersion()`` UWP alternative by thexai · Pull Request #152694 · python/cpython

Conversation

@thexai

@thexai thexai commented Jun 30, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Windows: _winapi.c implement GetVersion() UWP alternative.

  • Issue: Windows: improve compatibility to build for UWP / Xbox #152433

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thexai
pythongh-152433: Windows: _winapi.c implement GetVersion() UW…
23529c0 
…P alternative
@bedevere-app bedevere-app Bot mentioned this pull request Jun 30, 2026
Windows: improve compatibility to build for UWP / Xbox #152433
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jun 30, 2026
chris-eibl
chris-eibl approved these changes Jul 19, 2026
View reviewed changes

@chris-eibl chris-eibl left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I hardly think this will have any user on XBOX, though, and even on Desktop the main usage was for subprocess to check whether we're on Win9x

cpython/Lib/subprocess.py

Lines 1030 to 1033 in 23bba4c

if (_winapi.GetVersion() >= 0x80000000 or
os.path.basename(comspec).lower() == "command.com"):
# Win9x, or using command.com on NT. We need to
# use the w9xpopen intermediate program. For more

which has been ripped out a while ago. IOW, it is not used in the Python codebase itself anymore (but there might be users out there, even though starting with an underscore and GetVersion "lying" at you when running in compatibility / manifested mode).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 19, 2026
@chris-eibl
chris-eibl requested a review from a team July 19, 2026 12:11
@zooba
zooba merged commit 85ab112 into python:main Jul 20, 2026
60 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 20, 2026
@zooba

zooba commented Jul 20, 2026

Copy link
Copy Markdown
Member

GetVersion "lying" at you when running in compatibility / manifested mode

Well, other stuff that's typically directly linked to the version number also gets changed, so if you are trying to detect whether some API behaves a certain way by checking the version number, then you'll want the reported version number to match the compatibility shims that you're getting when you call the API. It's only a lie if your goal is to print the current version to a human, which is why the platform module is separate.
chris-eibl reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thexai
thexai deleted the uwp-getversion branch July 20, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-eibl chris-eibl chris-eibl approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@thexai @zooba @chris-eibl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.