GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98417: Stop modifying PyConfig in sys.set_int_max_str_digits() by gpshead · Pull Request #152869 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Jul 2, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PyConfig is an input to interpreter initialization; the copy stored on PyInterpreterState records how the interpreter was initialized. The runtime int<->str digit limit already lives in
PyInterpreterState.long_state.max_str_digits and that is what all readers use, so drop the write-back into
interp->config.int_max_str_digits from _PySys_SetIntMaxStrDigits().

As a consequence, interpreters created after a runtime limit change now start from the initially-configured limit instead of inheriting the current runtime value.

it's basically a one line change... the question is, is this what we want? we'll resolve that on the issue.

  • Issue: PyInterpreterState.config.int_max_str_digits Should Not Be Modified #98417

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@python-cla-bot

python-cla-bot Bot commented Jul 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Jul 2, 2026
PyInterpreterState.config.int_max_str_digits Should Not Be Modified #98417
Open
@gpshead @claude
pythongh-98417: Stop modifying PyConfig in sys.set_int_max_str_digits()
9675274 
PyConfig is an input to interpreter initialization; the copy stored on
PyInterpreterState records how the interpreter was initialized.  The
runtime int<->str digit limit already lives in
PyInterpreterState.long_state.max_str_digits and that is what all
readers use, so drop the write-back into
interp->config.int_max_str_digits from _PySys_SetIntMaxStrDigits().

As a consequence, interpreters created after a runtime limit change now
start from the initially-configured limit instead of inheriting the
current runtime value.

Co-Authored-By: Claude Fable 5 <[email protected]>
@gpshead
gpshead force-pushed the claude/cpython-98417-fix-6vqutb branch from 7115bfd to 9675274 Compare July 2, 2026 08:03
@gpshead
gpshead requested a review from zooba July 2, 2026 08:05
zooba
zooba approved these changes Jul 2, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Jul 2, 2026
@zooba

zooba commented Jul 2, 2026

Copy link
Copy Markdown
Member

I assume it won't change much on its way out of draft, but provided the change is just removing that line then I'm not going to have any concerns
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead
gpshead marked this pull request as ready for review July 5, 2026 20:53
@gpshead
gpshead requested a review from ericsnowcurrently as a code owner July 5, 2026 20:53
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting merge labels Jul 5, 2026
@gpshead gpshead added the needs backport to 3.15 bugs and security fixes label Jul 5, 2026
@gpshead

gpshead commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

it doesn't sound like we're settled on this as our behaviors around modifying PyConfig are not consistently read only any more per the issue. closing. we can reopen if this makes sense in the future.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead closed this Jul 5, 2026
@zooba

zooba commented Jul 6, 2026

Copy link
Copy Markdown
Member

our behaviors around modifying PyConfig are not consistently read only any more per the issue

Victor only showed that the C API is able to mutate it, which is always obviously possible (the PyConfig lives outside of the runtime, so the owner is the host app, and it can do whatever it likes).

A code snippet using the _testcapi module is hardly proof of inconsistency.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review needs backport to 3.15 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gpshead @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.