GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-151428: Remove unused imports in idlelib.idle_test (GH-151478) (GH-152916) by miss-islington · Pull Request #152917 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 2, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 984ebbf)

Co-authored-by: Terry Jan Reedy [email protected]

  • Issue: Remove unused imports (June 2026) #151428

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy @miss-islington
[3.15] pythongh-151428: Remove unused imports in idlelib.idle_test (p…
887cfb8 
…ythonGH-151478) (pythonGH-152916)

(cherry picked from commit 984ebbf)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington
miss-islington requested a review from terryjreedy as a code owner July 2, 2026 21:07
@bedevere-app bedevere-app Bot mentioned this pull request Jul 2, 2026
Remove unused imports (June 2026) #151428
Closed
@bedevere-app bedevere-app Bot added the skip news label Jul 2, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 2, 2026
[3.15] gh-151428: Remove unused imports in idlelib.idle_test (GH-151478) #152916
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jul 2, 2026
@terryjreedy
terryjreedy enabled auto-merge (squash) July 2, 2026 21:27
@terryjreedy

terryjreedy commented Jul 2, 2026

Copy link
Copy Markdown
Member

@serhiy-storchaka This 3.14 (only) backport of a trivial IDLE change has an unrelated test_tkinter failure.
macOS / build and test (macos-15-intel)
2026-07-02T21:17:33.0812420Z ======================================================================
2026-07-02T21:17:33.0814540Z �[31mFAIL�[0m�[1;31m: test_boundary_values_accepted (test.test_tkinter.test_simpledialog.QueryDialogTest.test_boundary_values_accepted)�[0m
2026-07-02T21:17:33.0816210Z ----------------------------------------------------------------------
2026-07-02T21:17:33.0816980Z Traceback (most recent call last):
2026-07-02T21:17:33.0818680Z File �[35m"/Users/runner/work/cpython/cpython/Lib/test/test_tkinter/test_simpledialog.py"�[0m, line �[35m244�[0m, in �[35mtest_boundary_values_accepted�[0m
2026-07-02T21:17:33.0820420Z �[31mself.assertEqual�[0m�[1;31m(d.result, 10)�[0m
2026-07-02T21:17:33.0821200Z �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^�[0m
2026-07-02T21:17:33.0821950Z �[1;35mAssertionError�[0m: �[35mNone != 10�[0m
2026-07-02T21:17:33.0822410Z
2026-07-02T21:17:33.0823790Z ======================================================================
2026-07-02T21:17:33.0825720Z �[31mFAIL�[0m�[1;31m: test_return_no_default (test.test_tkinter.test_simpledialog.SimpleDialogTest.test_return_no_default)�[0m
2026-07-02T21:17:33.0827240Z ----------------------------------------------------------------------
2026-07-02T21:17:33.0828240Z Traceback (most recent call last):
2026-07-02T21:17:33.0830340Z File �[35m"/Users/runner/work/cpython/cpython/Lib/test/test_tkinter/test_simpledialog.py"�[0m, line �[35m68�[0m, in �[35mtest_return_no_default�[0m
2026-07-02T21:17:33.0833220Z �[31mself.assertTrue�[0m�[1;31m(bells)�[0m # rang the bell
2026-07-02T21:17:33.0834560Z �[31m~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^�[0m
2026-07-02T21:17:33.0835520Z �[1;35mAssertionError�[0m: �[35m[] is not true�[0m

re-running
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
terryjreedy merged commit 8a2e34c into python:3.14 Jul 2, 2026
84 of 86 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Jul 2, 2026
@miss-islington
miss-islington deleted the backport-984ebbf-3.14 branch July 2, 2026 21:52
@terryjreedy

terryjreedy commented Jul 2, 2026

Copy link
Copy Markdown
Member

Rerun passed; possible timing error.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy terryjreedy added the needs backport to 3.13 only security fixes label Jul 3, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 3, 2026

Copy link
Copy Markdown

Thanks @miss-islington for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 3, 2026

Copy link
Copy Markdown

Sorry, @miss-islington and @terryjreedy, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8a2e34c9e002d85d81ed0f1c92cf7ed5c99a04ae 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned terryjreedy Jul 3, 2026
@serhiy-storchaka

serhiy-storchaka commented Jul 15, 2026

Copy link
Copy Markdown
Member

Please don't forget about backports.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Jul 29, 2026

Copy link
Copy Markdown
Member

No backport needed, these imports aren't in 3.13:

  • https://github.com/python/cpython/blob/3.13/Lib/idlelib/idle_test/template.py
  • https://github.com/python/cpython/blob/3.13/Lib/idlelib/idle_test/test_help.py
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk removed the needs backport to 3.13 only security fixes label Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @terryjreedy @serhiy-storchaka @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.