GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-152433: Windows: use ``CreateFile2`` on Windows UWP build by thexai · Pull Request #153021 · python/cpython

Conversation

@thexai

@thexai thexai commented Jul 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Windows: use CreateFile2 on Windows UWP build.

UWP does not support CreateFileW because it is only compatible with the Win32 desktop API.

CreateFile2 is available in all supported Windows versions (it could be used for everything) but for now created a wrapper to use only in UWP and avoid side effects or unexpected behavior changes on regular Windows builds.

UWP also needs convert absolute paths to relative paths due the security restrictions, so the wrapper solution is good because it does both things at the same time.

  • Issue: Windows: improve compatibility to build for UWP / Xbox #152433

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thexai
thexai requested a review from FFY00 as a code owner July 4, 2026 11:39
@bedevere-app bedevere-app Bot added the awaiting review label Jul 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 4, 2026
Windows: improve compatibility to build for UWP / Xbox #152433
Open
@thexai
thexai force-pushed the uwp-createfile branch 2 times, most recently from 0a1e0d9 to dc4ee4a Compare July 17, 2026 14:47
@thexai
thexai force-pushed the uwp-createfile branch from dc4ee4a to 3d9703d Compare August 3, 2026 10:04
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Nov 6, 2026
thexai added 2 commits November 7, 2026 09:52
@thexai
pythongh-152433: Windows: use CreateFile2 on Windows UWP build
1a0ca4e 
UWP does not support ``CreateFileW`` because it is only compatible
with the Win32 desktop API.
@thexai
Avoid define two times / duplicate code _Py_AbsolutePath_To_RelativePath
28f445c
@thexai
thexai force-pushed the uwp-createfile branch from 3d9703d to 28f445c Compare November 7, 2026 09:00
@thexai
thexai requested review from cmaloney and ericsnowcurrently as code owners November 7, 2026 09:00
@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Nov 7, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
@cmaloney cmaloney Awaiting requested review from cmaloney cmaloney is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@thexai
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.