GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.5] bpo-34155: Dont parse domains containing @ (GH-13079) by maxking · Pull Request #15317 · python/cpython

Conversation

@maxking

@maxking maxking commented Aug 17, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Before:

    >>> email.message_from_string('From: [email protected]@important.com', policy=email.policy.default)['from'].addresses
    (Address(display_name='', username='a', domain='malicious.org'),)

    >>> parseaddr('[email protected]@important.com')
    ('', '[email protected]')

After:

    >>> email.message_from_string('From: [email protected]@important.com', policy=email.policy.default)['from'].addresses
    (Address(display_name='', username='', domain=''),)

    >>> parseaddr('[email protected]@important.com')
    ('', 'a@')

https://bugs.python.org/issue34155
(cherry picked from commit 8cb65d1)

Co-authored-by: jpic [email protected]

https://bugs.python.org/issue34155

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jpic @maxking
[3.5] bpo-34155: Dont parse domains containing @ (pythonGH-13079)
2b98ade 
Before:

        >>> email.message_from_string('From: [email protected]@important.com', policy=email.policy.default)['from'].addresses
        (Address(display_name='', username='a', domain='malicious.org'),)

        >>> parseaddr('[email protected]@important.com')
        ('', '[email protected]')

    After:

        >>> email.message_from_string('From: [email protected]@important.com', policy=email.policy.default)['from'].addresses
        (Address(display_name='', username='', domain=''),)

        >>> parseaddr('[email protected]@important.com')
        ('', 'a@')

https://bugs.python.org/issue34155
(cherry picked from commit 8cb65d1)

Co-authored-by: jpic <[email protected]>
@bedevere-bot bedevere-bot added the type-security A security issue label Aug 17, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 17, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Aug 17, 2019
@alex
alex requested a review from larryhastings August 17, 2019 20:53
@alex

alex commented Aug 17, 2019

Copy link
Copy Markdown
Member

This needs a review from the 3.5 RM if this is going to be backported.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Aug 19, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: same change than 8cb65d1 already merged into master.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 19, 2019
@vstinner

vstinner commented Aug 19, 2019

Copy link
Copy Markdown
Member

@larryhastings: Would you mind to merge this security fix?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@larryhastings
larryhastings merged commit 063eba2 into python:3.5 Sep 7, 2019
@bedevere-bot

bedevere-bot commented Sep 7, 2019

Copy link
Copy Markdown

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 7, 2019
@larryhastings

larryhastings commented Sep 7, 2019

Copy link
Copy Markdown
Contributor

Thanks for the backport and the 3.5 love!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@larryhastings larryhastings Awaiting requested review from larryhastings

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@maxking @alex @vstinner @bedevere-bot @larryhastings @the-knights-who-say-ni @jpic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.