GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-37836: document as_integer_ratio() in the data model by jdemeyer · Pull Request #15328 · python/cpython

Conversation

@jdemeyer

@jdemeyer jdemeyer commented Aug 18, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue37836

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jdemeyer
bpo-37836: document as_integer_ratio() in the data model
76efe77
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 18, 2019
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 18, 2019
@rhettinger

rhettinger commented Aug 19, 2019

Copy link
Copy Markdown
Contributor

You should get Guido to opine on this. I think you're making this more official and pervasive and prescriptive than he intended.

There is a difference between making a helpful utility available versus trying to make everyone change their code to use it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger
rhettinger requested a review from gvanrossum August 19, 2019 00:35
gvanrossum
gvanrossum approved these changes Aug 19, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 19, 2019
@jdemeyer

jdemeyer commented Aug 19, 2019

Copy link
Copy Markdown
Contributor Author

I made this a draft PR since the doc says

This is used for conversion to :class:`fractions.Fraction`

but this is not yet true at the moment. So it depends on either #15327 (by me) or #15329 (by @serhiy-storchaka).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jdemeyer jdemeyer added the DO-NOT-MERGE label Aug 21, 2019
@jdemeyer
jdemeyer marked this pull request as ready for review August 21, 2019 09:33
@jdemeyer jdemeyer added the skip news label Aug 21, 2019
@jdemeyer jdemeyer mentioned this pull request Apr 21, 2022
Support .as_integer_ratio() in fractions.Fraction #82017
Closed
@AA-Turner

AA-Turner commented Jun 8, 2022

Copy link
Copy Markdown
Member

The linked issue was closed (#82017 (comment)) -- should this PR remain?

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Jun 8, 2022

Copy link
Copy Markdown
Member

Let's close it, since everything else related to this was closed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge DO-NOT-MERGE docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@jdemeyer @rhettinger @AA-Turner @gvanrossum @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.