GeezerVison is showing github.com — gh-151757: Skip curses variation-selector test on older macOS by serhiy-storchaka · Pull Request #153344 · python/cpython
Conversation
serhiy-storchaka
commented
Jul 8, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Older macOS reports a variation selector as a spacing character (wcwidth() returns 1) instead of a zero-width combining mark, so curses cannot place it in the same cell as its base character and test_addch_emoji raises ValueError.
curses groups cells by wcwidth(), the same as ncurses, so the assertion is only valid where the platform reports the selector as zero-width; skip it elsewhere.
The failure is confirmed on macOS 14.2 (reported in the issue) and gone by macOS 26, which CI runs, so 26 is the conservative cutoff.
🤖 Generated with Claude Code
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Older macOS reports a variation selector as a spacing character (wcwidth()
returns 1) instead of a zero-width combining mark, so curses cannot put it in
the same cell as its base. Skip that assertion there.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
|
Wow, thanks for such a quick fix! I will give it a try tomorrow and get back to you soon.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Hi, I have verified that the fix works for me :)
>>> platform.mac_ver()
('14.2', ('', '', ''), 'arm64')
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Thank you for verification.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|