GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-151757: Skip curses variation-selector test on older macOS by serhiy-storchaka · Pull Request #153344 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 8, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Older macOS reports a variation selector as a spacing character (wcwidth() returns 1) instead of a zero-width combining mark, so curses cannot place it in the same cell as its base character and test_addch_emoji raises ValueError.
curses groups cells by wcwidth(), the same as ncurses, so the assertion is only valid where the platform reports the selector as zero-width; skip it elsewhere.

The failure is confirmed on macOS 14.2 (reported in the issue) and gone by macOS 26, which CI runs, so 26 is the conservative cutoff.

🤖 Generated with Claude Code

  • Issue: Add wide-character (cchar_t) support to the curses module #151757

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka @claude
pythongh-151757: Skip curses variation-selector test on older macOS
81551e4
Older macOS reports a variation selector as a spacing character (wcwidth()
returns 1) instead of a zero-width combining mark, so curses cannot put it in
the same cell as its base.  Skip that assertion there.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jul 8, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 8, 2026
Add wide-character (cchar_t) support to the curses module #151757
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 8, 2026
@weixlu

weixlu commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Wow, thanks for such a quick fix! I will give it a try tomorrow and get back to you soon.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka serhiy-storchaka added the skip news label Jul 8, 2026
@weixlu

weixlu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Hi, I have verified that the fix works for me :)

>>> platform.mac_ver()
('14.2', ('', '', ''), 'arm64')
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
serhiy-storchaka merged commit f3fd9dc into python:main Jul 9, 2026
53 of 54 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 9, 2026
@serhiy-storchaka
serhiy-storchaka deleted the curses-test-vs16-wcwidth branch July 9, 2026 06:28
@serhiy-storchaka

serhiy-storchaka commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

Thank you for verification.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @weixlu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.