GeezerVison is showing github.com — gh-153634: Raise csv.Error, not ValueError, from csv.Sniffer for an inconsistent guessed dialect by tonghuaroot · Pull Request #153635 · python/cpython
Conversation
tonghuaroot
commented
Jul 13, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
csv.Sniffer.sniff() could return a dialect whose delimiter equals its quotechar, so using it (directly or via has_header) leaked a raw ValueError from _csv instead of csv.Error. Validate the guessed dialect before returning it and re-raise the ValueError as csv.Error; the throwaway reader validates the full _csv invariant set, so future _guess_* changes cannot silently return another invalid dialect.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…r an inconsistent guessed dialect
csv.Sniffer.sniff could return a dialect whose delimiter equaled its quote character. Using that dialect (directly, or via csv.Sniffer.has_header, which builds a reader from the sniffed dialect) leaked a raw ValueError from the _csv extension instead of the module's own csv.Error. sniff now validates its guessed dialect before returning it and re-raises the _csv ValueError as csv.Error, so both sniff and has_header report the module exception type. The direct csv.reader and csv.writer paths and the Dialect._validate TypeError/ValueError behavior are unchanged.
|
Thank you for the patch, but I think that the fix should be made earlier: the delimiter should not be guessed to be the detected quote character in the first place. _guess_quote_and_delimiter() already excludes quote characters from the delimiter candidates, and only _guess_delimiter(), which counts the frequency of every ASCII character, can return one.
Note also that on the main branch the sniffer was rewritten (gh-83273) and it already raises csv.Error for these samples, so this change is only needed for the maintenance branches.
|
tonghuaroot reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.