GeezerVison is showing github.com — gh-153648: Deprecate http.client.HTTPMessage.getallmatchingheaders() by soreavis · Pull Request #153649 · python/cpython
Conversation
soreavis
commented
Jul 13, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
getallmatchingheaders() has returned an empty list for every input since Python 3.0 — it compares keys() entries, which are bare header names, against "name:". Its only user was the CGI handler, which was removed in 3.15, and run_cgi() had already stopped calling it in 3.10.
Deprecate it, with removal in 3.18. That is PEP 387's minimum window rather than the usual five years, on the grounds that the method has never worked and has had no callers for five releases — happy to push it out to 3.21 if you'd rather keep it in line with the other 3.16 deprecations.
Use email.message.Message.get_all() instead.
#153648
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…ers()
getallmatchingheaders() has returned an empty list for every input since
Python 3.0 -- it compares keys() entries, which are bare header names,
against "name:". Its only user was the CGI handler, removed in 3.15, and
run_cgi() had already stopped calling it in 3.10.
Deprecate it, with removal in 3.18. Use email.message.Message.get_all()
instead.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good but just a nit.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 90 days with no activity.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
picnixz
picnixz left review comments
AA-Turner
Awaiting requested review from AA-Turner
AA-Turner is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.