GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-149816: Fix UAF in Modules/_pickle.c (GH-150024) by nascheme · Pull Request #153719 · python/cpython

Conversation

@nascheme

@nascheme nascheme commented Jul 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

gh-149816: Fix UAF in Modules/_pickle.c (GH-150024)

Backport note: 3.14's batch_list_exact() has the single-item fast path before the batch loop; main moved it inside the loop, which changes the emitted pickle byte stream (APPEND vs MARK ... APPENDS for a trailing single item). To avoid changing 3.14's pickle output, 3.14's structure was kept and only the fix applied: the borrowed PyList_GET_ITEM() + Py_INCREF() became PyList_GetItemRef(), and the list changed size during iteration RuntimeError check was added after each batch. The upstream regression test (test_pickle_dumps_with_concurrent_list_mutations) tolerates RuntimeError/IndexError and passes unchanged.

(cherry picked from commit d095ceb)

Co-authored-by: Alexey Katsman [email protected]
Co-authored-by: Gregory P. Smith [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@alexkats @gpshead @nascheme
[3.14] pythongh-149816: Fix UAF in Modules/_pickle.c (pythonGH-150024)
758eb91
(cherry picked from commit d095ceb)

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Alexey Katsman <[email protected]>
@python-cla-bot

python-cla-bot Bot commented Jul 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot mentioned this pull request Jul 14, 2026
22 free-threading race conditions #149816
Open
13 of 24 tasks
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 14, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 14, 2026
gh-149816: Fix UAF in Modules/_pickle.c #150024
Merged
@nascheme nascheme mentioned this pull request Jul 16, 2026
Backport free-threading memory-safety fixes to 3.14 and 3.15 #153714
Closed
kumaraditya303
kumaraditya303 approved these changes Jul 16, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 16, 2026
@nascheme
nascheme merged commit 7ed9b91 into python:3.14 Jul 17, 2026
53 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 17, 2026
@nascheme
nascheme deleted the ft-backport/gh-149816-3.14 branch July 17, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@nascheme @kumaraditya303 @alexkats
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.