GeezerVison is showing github.com — gh-145559: Make PyUnstable_DumpTraceback return void again by hoodmane · Pull Request #154131 · python/cpython
Conversation
hoodmane
commented
Jul 19, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
In gh-148145, we changed this to return a const char* but it is always NULL. I don't think this makes sense, so this puts it back.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
In pythongh-148145, we changed this to return a const char* but it is always NULL. I
don't think this makes sense, so this puts it back.
hoodmane
changed the title
gh-145559: Make PyUnstable_DumpTraceback void return
gh-145559: Make PyUnstable_DumpTraceback return void again
Jul 19, 2026
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
const char* return type is a deliberate choice. See for example:
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Makes sense, thanks! (I asked @encukou in person and he didn't remember the discussion about this.)
|
vstinner reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
vstinner
Awaiting requested review from vstinner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.