GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-154517: Document OpenSSL version requirements and post-quantum groups for the ssl group and signature algorithm APIs by fedonman · Pull Request #154518 · python/cpython

Conversation

@fedonman

@fedonman fedonman commented Jul 23, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Five ssl functions and methods added in 3.15 need a specific OpenSSL version and raise NotImplementedError on older ones, which the reference docs didn't say. This adds that note to each, points set_ecdh_curve() at set_groups(), and mentions post-quantum hybrid groups in the TLS 1.3 section.

  • Issue: Document OpenSSL version requirements and post-quantum groups for the ssl group and signature algorithm APIs #154517

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@fedonman
pythongh-154517: Document OpenSSL version requirements and post-quant…
2940b06 
…um groups for the ssl group API
@fedonman
fedonman requested review from gpshead and picnixz as code owners July 23, 2026 02:37
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jul 23, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Jul 23, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jul 23, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 23, 2026
Document OpenSSL version requirements and post-quantum groups for the ssl group and signature algorithm APIs #154517
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jul 23, 2026
@fedonman
pythongh-154517: Add myself to Misc/ACKS
97975e0
@read-the-docs-community

read-the-docs-community Bot commented Jul 23, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34091364 | 📁 Comparing a8c5295 against main (206788a)

  🔍 Preview build  

77 files changed · ± 77 modified

± Modified

  • index.html
  • license.html
  • c-api/arg.html
  • c-api/capsule.html
  • c-api/exceptions.html
  • c-api/frame.html
  • c-api/init_config.html
  • c-api/intro.html
  • c-api/stable.html
  • c-api/sys.html
  • and 67 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fedonman
Merge branch 'main' into docs-ssl-pqc-groups
e56cc61
@fedonman fedonman mentioned this pull request Jul 23, 2026
gh-138252: Document OpenSSL version requirements for the ssl signature-algorithm APIs #154521
Closed
@fedonman
pythongh-154517: Document OpenSSL version requirements for the ssl si…
eaa471a 
…gnature algorithm APIs
@fedonman fedonman changed the title gh-154517: Document OpenSSL version requirements and post-quantum groups for the ssl group API gh-154517: Document OpenSSL version requirements and post-quantum groups for the ssl group and signature algorithm APIs Jul 26, 2026
@fedonman
Merge branch 'main' into docs-ssl-pqc-groups
6c94325
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.15 bugs and security fixes label Aug 16, 2026
@serhiy-storchaka

serhiy-storchaka commented Aug 16, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The wording differs from what this file uses elsewhere. For methods it says "This method will raise :exc:`NotImplementedError` if :data:`HAS_PSK` is ``False``", and for versions "This option is only available with OpenSSL 3.0.0 and later". Something like

   This method will raise :exc:`NotImplementedError` if the OpenSSL library
   is older than 3.2.

would fit better, and since the same sentence is repeated five times it is worth choosing one form.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Aug 16, 2026
View reviewed changes
Comment thread Doc/library/ssl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Aug 16, 2026
View reviewed changes
Comment thread Doc/library/ssl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz requested changes Aug 16, 2026
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unrelated changes that look AI generated. Remove them and please review your AI output before committing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Aug 16, 2026
@bedevere-app

bedevere-app Bot commented Aug 16, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fedonman
Address review: match existing wording, drop set_groups() example
a8c5295 
Use the phrasing already used in this file for the five version notes,
as suggested by serhiy-storchaka.  Remove the set_groups() example and
post-quantum paragraph, which restate the OpenSSL documentation, and
drop the redundant claim that OpenSSL 3.5 offers hybrid groups by
default.
@fedonman

fedonman commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

Thanks. All five now use the form already in this file:

   This method will raise :exc:`NotImplementedError` if the OpenSSL library
   is older than 3.2.

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Aug 16, 2026
@bedevere-app

bedevere-app Bot commented Aug 16, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from picnixz August 16, 2026 17:26
@fedonman

fedonman commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@picnixz, could you take another look when you have time?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting change review docs Documentation in the Doc dir needs backport to 3.15 bugs and security fixes skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@fedonman @serhiy-storchaka @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.