GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-154539: Use atomic read and write with `should_auto_add_history` by xxyzz · Pull Request #154531 · python/cpython

Conversation

@xxyzz

@xxyzz xxyzz commented Jul 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fix the variable race problem TSAN-0025 in gh-153852

  • Issue: Data race of should_auto_add_history in file Modules/readline.c #154539

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xxyzz xxyzz mentioned this pull request Jul 23, 2026
Free-threading data races in CPython: 15 findings (9 new + 6 residual of existing FT work) #153852
Open
@bedevere-app

bedevere-app Bot commented Jul 23, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Jul 23, 2026
@brijkapadia

brijkapadia commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

This PR needs an issue.
Can you create a new issue that summarizes TSAN-0025 and link this PR to that new issue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xxyzz
pythongh-154539: Use atomic read and write with `should_auto_add_hist…
4be5829 
…ory`

Fix the variable race problem TSAN-0025 in pythongh-153852
@xxyzz
xxyzz force-pushed the tsan-0025 branch from b842fd3 to 4be5829 Compare July 23, 2026 12:56
@bedevere-app

bedevere-app Bot commented Jul 23, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xxyzz xxyzz changed the title Use atomic read and write with should_auto_add_history gh-154539: Use atomic read and write with should_auto_add_history Jul 23, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 23, 2026
Data race of should_auto_add_history in file Modules/readline.c #154539
Open
@github-actions

github-actions Bot commented Oct 28, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@xxyzz @brijkapadia
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.