GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-154577: Fix data race in `Modules/cjkcodecs/multibytecodec.c` by xxyzz · Pull Request #154578 · python/cpython

Conversation

@xxyzz

@xxyzz xxyzz commented Jul 24, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Prevent race by adding @critical_section to functions that have MultibyteIncrementalEncoderObject or
MultibyteIncrementalDecoderObject argument

Fix TSAN-0001 from gh-153852

  • Issue: Data race in Modules/cjkcodecs/multibytecodec.c #154577

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xxyzz
xxyzz requested a review from corona10 as a code owner July 24, 2026 06:22
@bedevere-app bedevere-app Bot mentioned this pull request Jul 24, 2026
Data race in Modules/cjkcodecs/multibytecodec.c #154577
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jul 24, 2026
@xxyzz
xxyzz force-pushed the tsan-0001 branch from 2b54d9c to f7625e0 Compare July 24, 2026 06:26
BHUVANSH855
BHUVANSH855 reviewed Jul 26, 2026
View reviewed changes

@BHUVANSH855 BHUVANSH855 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the failing Docs job is caused by these :c:type: references. Since MultibyteIncrementalEncoderObject and MultibyteIncrementalDecoderObject are internal implementation types rather than documented C API types, Sphinx can't resolve them and reports unresolved c:type references.

Would it make sense to use code literals (MultibyteIncrementalEncoderObject / MultibyteIncrementalDecoderObject) or simply describe them as the incremental encoder/decoder objects instead? That should avoid the documentation warning while still conveying the intent.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xxyzz
pythongh-154577: Fix data race in Modules/cjkcodecs/multibytecodec.c
3ba7336 
Prevent race by adding `@critical_section` to functions that have
`MultibyteIncrementalEncoderObject` or
`MultibyteIncrementalDecoderObject` argument

Fix TSAN-0001 from pythongh-153852
@xxyzz
xxyzz force-pushed the tsan-0001 branch from f7625e0 to 3ba7336 Compare July 26, 2026 23:02
@xxyzz

xxyzz commented Jul 26, 2026

Copy link
Copy Markdown
Author

Thanks! Docs check should pass now.
BHUVANSH855 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
1 more reviewer
@BHUVANSH855 BHUVANSH855 BHUVANSH855 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@xxyzz @BHUVANSH855
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.