GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] GH-115869: Make jit_stencils.h reproducible (GH-127166) by bmwiedemann · Pull Request #154988 · python/cpython

Conversation

@bmwiedemann

@bmwiedemann bmwiedemann commented Jul 31, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Keep the build tmpdir out of jit_stencils.h

llvm-objdump prints the path of the object file it disassembles, and the JIT builds every stencil in a fresh tempfile.TemporaryDirectory(). That random path ended up verbatim in the disassembly comments of the generated jit_stencils.h, so two builds of the same source never produced the same header:

 // /tmp/tmp164olvmi/_BINARY_OP.o:  file format elf64-x86-64
+// /tmp/tmpmufvewt2/_BINARY_OP.o:  file format elf64-x86-64

Replace the full path with the bare file name.

Only the _parse() hunk of that commit is taken here; the rest of it depends on refactorings that are not in 3.13.

(cherry picked from commit 17c16ae)

I tested that it works.

This PR was done while working on reproducible builds for openSUSE.

  • Issue: Hosting jit_stencils.h #115869

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bmwiedemann
bmwiedemann requested review from brandtbucher and savannahostrowski as code owners July 31, 2026 10:45
@bedevere-app bedevere-app Bot mentioned this pull request Jul 31, 2026
Hosting jit_stencils.h #115869
Open
@bedevere-app bedevere-app Bot added the topic-JIT label Jul 31, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 31, 2026
GH-115869: Make jit_stencils.h reproducible #127166
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jul 31, 2026
@bmwiedemann
bmwiedemann force-pushed the gh115869 branch from d943650 to a49dcfa Compare July 31, 2026 10:50
mcepl
mcepl reviewed Jul 31, 2026
View reviewed changes

@mcepl mcepl left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bmwiedemann @brandtbucher
[3.13] pythonGH-115869: Make jit_stencils.h reproducible (pythonGH-12…
eb1d107 
…7166)

Keep the build tmpdir out of jit_stencils.h

llvm-objdump prints the path of the object file it disassembles, and the
JIT builds every stencil in a fresh tempfile.TemporaryDirectory().  That
random path ended up verbatim in the disassembly comments of the
generated jit_stencils.h, so two builds of the same source never produced
the same header:

     // /tmp/tmp164olvmi/_BINARY_OP.o:  file format elf64-x86-64
    +// /tmp/tmpmufvewt2/_BINARY_OP.o:  file format elf64-x86-64

Replace the full path with the bare file name.

Only the _parse() hunk of that commit is taken here; the rest of it
depends on refactorings that are not in 3.13.

(cherry picked from commit 17c16ae)

Co-authored-by: Brandt Bucher <[email protected]>
@bmwiedemann
bmwiedemann force-pushed the gh115869 branch from a49dcfa to eb1d107 Compare July 31, 2026 10:52
@Yhg1s
Yhg1s merged commit 9b67007 into python:3.13 Aug 4, 2026
52 of 54 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Aug 4, 2026
@bmwiedemann
bmwiedemann deleted the gh115869 branch August 6, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner
1 more reviewer
@mcepl mcepl mcepl left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bmwiedemann @mcepl @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.